vacuum_interval for prometheus Export #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a parameter that defines a fixed intervall at which all prometheus exporter counters are getting reset
debugloop
reviewed
Dec 7, 2024
| MetricsPath string // optional, default is "/metrics" | ||
| FlowdataPath string // optional, default is "/flowdata" | ||
| Labels []string // optional, list of labels to be exported | ||
| VacuumInterval *time.Duration // optional, intervall in which counters should be reset |
There was a problem hiding this comment.
We should add some emphasis and warning that vacuuming might happen at an inconvenient time which leads to some data loss (at most about one scrape interval's worth).
I believe it might be possible to hook the next Gather operation and only vacuum then, which would prevent most of the possible data loss 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a parameter that defines a fixed intervall at which all prometheus exporter counters are getting reset
Fixes #80