Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow kwdef macro outside of definition of struct #18

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

Tortar
Copy link
Contributor

@Tortar Tortar commented Oct 11, 2023

Fixes #15

Maybe too hard coded as removal, will improve that

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (77ed9ed) 97.18% compared to head (b6688f2) 94.36%.

❗ Current head b6688f2 differs from pull request most recent head 6b7102b. Consider uploading reports for the commit 6b7102b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   97.18%   94.36%   -2.82%     
==========================================
  Files           2        2              
  Lines          71       71              
==========================================
- Hits           69       67       -2     
- Misses          2        4       +2     
Files Coverage Δ
src/ProtoStruct.jl 94.28% <100.00%> (-2.86%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tortar
Copy link
Contributor Author

Tortar commented Oct 11, 2023

should be okay now

@BeastyBlacksmith BeastyBlacksmith merged commit 32acc26 into BeastyBlacksmith:master Oct 13, 2023
1 of 15 checks passed
@Tortar Tortar deleted the patch-2 branch October 14, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with kwdef macro
2 participants