Add length check guards for delete methods (#31)

* Add length check guards for delete methods * add test * Update test_ProtoStruct.jl * Update test_ProtoStruct.jl * Update test_ProtoStruct.jl * Update test_ProtoStruct.jl --------- Co-authored-by: Simon Christ <[email protected]> Co-authored-by: Simon Christ <[email protected]>
BeastyBlacksmith · Jan 12, 2024 · df875e2 · df875e2
1 parent e1124d9
commit df875e2
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 4 deletions.
diff --git a/src/ProtoStruct.jl b/src/ProtoStruct.jl
@@ -116,8 +116,12 @@ macro proto(expr)
                         error("The supertype of a proto struct is not redefinable. Please restart your julia session.")
                     end
                     the_methods = collect(methods($name))
-                    Base.delete_method(the_methods[1])
-                    Base.delete_method(the_methods[2])
+                    if length(the_methods) >= 1
+                        Base.delete_method(the_methods[1])
+                    end
+                    if length(the_methods) >= 2
+                        Base.delete_method(the_methods[2])
+                    end
                 end
 
                 function $name($(fields...)) where {$(type_parameters...)}
@@ -181,8 +185,12 @@ macro proto(expr)
                         error("The supertype of a proto struct is not redefinable. Please restart your julia session.")
                     end
                     the_methods = collect(methods($name))
-                    Base.delete_method(the_methods[1])
-                    Base.delete_method(the_methods[2])
+                    if length(the_methods) >= 1
+                        Base.delete_method(the_methods[1])
+                    end
+                    if length(the_methods) >= 2
+                        Base.delete_method(the_methods[2])
+                    end
                 end
 
                 function $name($(fields...)) where {$(type_parameters...)}

diff --git a/test/test_ProtoStruct.jl b/test/test_ProtoStruct.jl
@@ -168,6 +168,21 @@ end
     end
 end
 
+@proto struct TestMethods end
+
+@testset "Constuctor updating I" begin
+    @test length(collect(methods(TestMethods))) == 1
+end
+
+@proto struct TestMethods
+        a
+        b
+end
+
+@testset "Constuctor updating II" begin
+    @test length(collect(methods(TestMethods))) == 2
+end
+
 """
 This is a docstring.
 """