Error on redefinition of Abstract Type (#25)

* Error on redefinition of Abstract Type * Update ProtoStruct.jl * Update ProtoStructs.jl * Update Project.toml * Update ProtoStructs.jl * Remove InteractiveUtils dependency --------- Co-authored-by: Simon Christ <[email protected]>
BeastyBlacksmith · Oct 16, 2023 · da2620e · da2620e
1 parent 63c20c8
commit da2620e
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/src/ProtoStruct.jl b/src/ProtoStruct.jl
@@ -110,6 +110,9 @@ macro proto(expr)
                         properties::NT
                     end
                 else
+                    if ($abstract_type != Any) && ($abstract_type != Base.supertype($name))
+                        error("The supertype of a proto struct is not redefinable. Please restart your julia session.")
+                    end
                     the_methods = collect(methods($name))
                     Base.delete_method(the_methods[1])
                     Base.delete_method(the_methods[2])
@@ -165,6 +168,9 @@ macro proto(expr)
                         properties::NT
                     end
                 else
+                    if ($abstract_type != Any) && ($abstract_type != Base.supertype($name))
+                        error("The supertype of a proto struct is not redefinable. Please restart your julia session.")
+                    end
                     the_methods = collect(methods($name))
                     Base.delete_method(the_methods[1])
                     Base.delete_method(the_methods[2])

diff --git a/src/ProtoStructs.jl b/src/ProtoStructs.jl
@@ -4,4 +4,4 @@ export @proto
 
 include("ProtoStruct.jl")
 
-end # module
+end
diff --git a/test/test_ProtoStruct.jl b/test/test_ProtoStruct.jl
@@ -138,6 +138,13 @@ end
     tpm = @test_nowarn TestParametricMutation(D = 1, E = "yepp")
     @test tpm isa TestParametricMutation{Int}
     @test tpm isa AbstractMutation
+    @test_throws ErrorException @proto mutable struct TestParametricMutation{V<:Integer} <: Number
+            A::Int = 1
+            B = :no
+            C::Nothing = nothing
+            D::V
+            E::String
+        end
 end
 
 @static if VERSION >= v"1.8"
Original file line number	Diff line number	Diff line change
Expand Up		@@ -4,4 +4,4 @@ export @proto

		include("ProtoStruct.jl")

		end # module
		end