Fix show for const properties of type Vector or Symbol (#29)

* fix access to empty vector for const fields * trigger CI * fix syntax error and printing of symbols * don't print in tests --------- Co-authored-by: Simon Christ <[email protected]>
BeastyBlacksmith · Nov 10, 2023 · 872efcc · 872efcc
1 parent d1db7a1
commit 872efcc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/ProtoStruct.jl b/src/ProtoStruct.jl
@@ -161,7 +161,7 @@ macro proto(expr)
                 end
 
                 function Base.show(io::IO, o::$name)
-                    vals = join([x[] isa String ? "\"$(x[])\"" : x[] for x in getfield(o, :properties)], ", ")
+                    vals = join([x isa Base.RefValue ? (x[] isa String ? "\"$(x[])\"" : x[]) : x for x in getfield(o, :properties)], ", ")
                     params = typeof(o).parameters[1:end-$N_any_params-1]
                     if isempty(params)
                         print(io, string($name), "($vals)")

diff --git a/test/test_ProtoStruct.jl b/test/test_ProtoStruct.jl
@@ -153,13 +153,15 @@ end
         const B = :no
         const C::T = 3
         D
+        const E::Vector{Int} = Int[]
     end
 
     @testset "const fields" begin
         cf = @test_nowarn WithConstFields(D = 1.2)
         @test cf.A == 1
         @test cf.B == :no
         @test cf.C == 3
+        @test_nowarn show(devnull, cf)
         cf.A = 5
         @test_throws ErrorException cf.B = :yes
         @test_throws ErrorException cf.C = 5