Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EBIP-13 #682

Merged
merged 8 commits into from
Nov 9, 2023
Merged

EBIP-13 #682

merged 8 commits into from
Nov 9, 2023

Conversation

BrendanSanderson
Copy link
Contributor

@BrendanSanderson BrendanSanderson commented Nov 9, 2023

EBIP-13: Re-Add Convert

Submitter

Beanstalk Community Multisig

Summary

Re-add the convert function with a new implementation that fixes the bug from EBIP-12.

Links

Per the process outlined in the BCM Emergency Response Procedures, the BCM can take swift action to protect Beanstalk in the event of a bug or security vulnerability.

In the case of EBIP-13, functionality that was removed in EBIP-12 is reintroduced this EBIP.

Problem

The convert function was removed in EBIP-12.

Solution

Add require statements in LibWellConvert that verify that the Well being Converted in is whitelisted.

Add a require statement in ConvertFacet that verifies that the token amount being Converted from is greater than 0.

Re-add the convert function to Beanstalk.

All changes were reviewed by Cyfrin.

Contract Changes

Convert Facet

The following ConvertFacet is added to Beanstalk:

ConvertFacet Function Changes

Name Selector Action Type New Functionality
convert 0xb362a6e8 Add Call

Event Changes

None.

Beans Minted

None.

Effective

Effective immediately upon commitment by the BCM, which has already happened.

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for basin canceled.

Name Link
🔨 Latest commit 77996e4
🔍 Latest deploy log https://app.netlify.com/sites/basin/deploys/654d4c98fe35260008344c15

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for beanstalk-ui canceled.

Name Link
🔨 Latest commit 77996e4
🔍 Latest deploy log https://app.netlify.com/sites/beanstalk-ui/deploys/654d4c98237a5f0008ca9cd9

@BrendanSanderson BrendanSanderson merged commit 1c6f556 into master Nov 9, 2023
8 checks passed
@BrendanSanderson BrendanSanderson deleted the ebip-13 branch November 9, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant