Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EBIP-13: Re-Add Convert
Submitter
Beanstalk Community Multisig
Summary
Re-add the
convert
function with a new implementation that fixes the bug from EBIP-12.Links
Per the process outlined in the BCM Emergency Response Procedures, the BCM can take swift action to protect Beanstalk in the event of a bug or security vulnerability.
In the case of EBIP-13, functionality that was removed in EBIP-12 is reintroduced this EBIP.
Problem
The
convert
function was removed in EBIP-12.Solution
Add
require
statements inLibWellConvert
that verify that the Well being Converted in is whitelisted.Add a
require
statement inConvertFacet
that verifies that the token amount being Converted from is greater than 0.Re-add the
convert
function to Beanstalk.All changes were reviewed by Cyfrin.
Contract Changes
Convert Facet
The following
ConvertFacet
is added to Beanstalk:0x7d19277B836D4787dC338251fbEd2e5841cF8c02
ConvertFacet
Function Changesconvert
0xb362a6e8
Event Changes
None.
Beans Minted
None.
Effective
Effective immediately upon commitment by the BCM, which has already happened.