Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the findings found from the codeArena remediation audit.
PRICE_THRESHOLD
from 100 to 10, used incalcReservesAtRatioSwap
andcalcReserveAtRatioLiquidity
. This significantly increases the accuracy of the reserve with a marginal increase in gas.calcLpTokenSupply
would not converge at extreme ratios, and would instead oscillate +/- 2 unit around the target value. An boolean check was added if this case occurred, which stops the infinite loop and return the average.