Update stable2 LUT tests

BeanstalkFarms · Jul 16, 2024 · fb2e36c · fb2e36c
1 parent 427ad85
commit fb2e36c
Showing 1 changed file with 40 additions and 25 deletions.
diff --git a/test/Stable2/LookupTable.t.sol b/test/Stable2/LookupTable.t.sol
@@ -1,115 +1,131 @@
 // SPDX-License-Identifier: MIT
+// forgefmt: disable-start
+
 pragma solidity ^0.8.20;
 
 import {TestHelper, Well, IERC20, console} from "test/TestHelper.sol";
-import {Stable2LUT1} from "src/functions/StableLut/Stable2LUT1.sol";
+import {Stable2LUT1} from "src/functions/StableLUT/Stable2LUT1.sol";
 
 contract LookupTableTest is TestHelper {
+
     Stable2LUT1 lookupTable;
     Stable2LUT1.PriceData pd;
 
     function setUp() public {
         lookupTable = new Stable2LUT1();
     }
 
-    function test_getAParameter() public view {
+    function test_getAParameter() public {
         uint256 a = lookupTable.getAParameter();
-        assertEq(a, 1);
+        assertEq(a , 1);
     }
 
     //////////////// getRatiosFromPriceSwap ////////////////
 
     function test_getRatiosFromPriceSwapAroundDollarHigh() public {
         uint256 currentPrice = 1e6;
         // test 1.0 - 1.10 range
-        for (uint256 i; i < 10; i++) {
+        for (uint256 i;  i<10 ; i++) {
             pd = lookupTable.getRatiosFromPriceSwap(currentPrice);
             uint256 diff = pd.highPrice - pd.lowPrice;
-            assertLt(diff, 0.08e6);
+            // 2 cent precision around the dollar mark
+            assertLt(diff, 0.02e6);
             currentPrice += 0.01e6;
         }
     }
 
     function test_getRatiosFromPriceSwapAroundDollarLow() public {
         uint256 currentPrice = 0.9e6;
         // test 0.9 - 1.0 range
-        for (uint256 i; i < 10; i++) {
+        for (uint256 i;  i<10 ; i++) {
             pd = lookupTable.getRatiosFromPriceSwap(currentPrice);
             uint256 diff = pd.highPrice - pd.lowPrice;
-            assertLt(diff, 0.08e18);
-            currentPrice += 0.01e6;
+            // 2 cent precision around the dollar mark
+            assertLt(diff, 0.02e6);
+            currentPrice += 0.02e6;
         }
     }
 
     function test_getRatiosFromPriceSwapExtremeLow() public {
-        // pick a value close to the min (P=0.01)
+        // pick a value close to the min (P~=0.01)
         uint256 currentPrice = 0.015e6;
         pd = lookupTable.getRatiosFromPriceSwap(currentPrice);
     }
 
     function test_getRatiosFromPriceSwapExtremeHigh() public {
-        // pick a value close to the max (P=9.85)
+        // pick a value close to the max (P~=10)
         uint256 currentPrice = 9.84e6;
         pd = lookupTable.getRatiosFromPriceSwap(currentPrice);
     }
 
     function testFail_getRatiosFromPriceSwapExtremeLow() public {
         // pick an out of bounds value (P<0.01)
-        uint256 currentPrice = 0.001e6;
+        uint256 currentPrice = 0.0001e6;
         pd = lookupTable.getRatiosFromPriceSwap(currentPrice);
+        // assert no revert
+        assert(pd.highPrice > pd.lowPrice);
     }
 
     function testFail_getRatiosFromPriceSwapExtremeHigh() public {
-        // pick an out of bounds value (P>10.37)
-        uint256 currentPrice = 11e6;
+        // pick an out of bounds value (P>10)
+        uint256 currentPrice = 100e6;
         pd = lookupTable.getRatiosFromPriceSwap(currentPrice);
+        // assert no revert
+        assert(pd.highPrice > pd.lowPrice);
     }
 
     //////////////// getRatiosFromPriceLiquidity ////////////////
 
+
     function test_getRatiosFromPriceLiquidityAroundDollarHigh() public {
         uint256 currentPrice = 1e6;
         // test 1.0 - 1.10 range
-        for (uint256 i; i < 10; i++) {
+        for (uint256 i;  i<10 ; i++) {
             pd = lookupTable.getRatiosFromPriceLiquidity(currentPrice);
             uint256 diff = pd.highPrice - pd.lowPrice;
-            assertLt(diff, 0.08e6);
+            // 2 cent precision around the dollar mark
+            assertLt(diff, 0.02e6);
             currentPrice += 0.01e6;
         }
     }
 
     function test_getRatiosFromPriceLiquidityAroundDollarLow() public {
         uint256 currentPrice = 0.9e6;
         // test 0.9 - 1.0 range
-        for (uint256 i; i < 10; i++) {
+        for (uint256 i;  i<10 ; i++) {
             pd = lookupTable.getRatiosFromPriceLiquidity(currentPrice);
             uint256 diff = pd.highPrice - pd.lowPrice;
-            assertLt(diff, 0.1e6);
+            // 2 cent precision around the dollar mark
+            assertLt(diff, 0.02e6);
             currentPrice += 0.01e6;
         }
     }
 
     function test_getRatiosFromPriceLiquidityExtremeLow() public {
-        // pick a value close to the min (P=0.01)
+        // pick a value close to the min (P=~0.01)
         uint256 currentPrice = 0.015e6;
         pd = lookupTable.getRatiosFromPriceLiquidity(currentPrice);
+        // assert no revert
+        assert(pd.highPrice > pd.lowPrice);
     }
 
     function test_getRatiosFromPriceLiquidityExtremeHigh() public {
-        // pick a value close to the max (P=9.92)
+        // pick a value close to the max (P~=10)
         uint256 currentPrice = 9.91e6;
         pd = lookupTable.getRatiosFromPriceLiquidity(currentPrice);
+        // assert no revert
+        assert(pd.highPrice > pd.lowPrice);
     }
 
     function testFail_getRatiosFromPriceLiquidityExtremeLow() public {
         // pick an out of bounds value (P<0.01)
-        uint256 currentPrice = 0.001e6;
+        uint256 currentPrice = 0.00001e6;
         pd = lookupTable.getRatiosFromPriceLiquidity(currentPrice);
     }
 
     function testFail_getRatiosFromPriceLiquidityExtremeHigh() public {
-        // pick an out of bounds value (P>10.37)
-        uint256 currentPrice = 11e6;
+        // pick an out of bounds value (P>10)
+        uint256 currentPrice = 100e6;
         pd = lookupTable.getRatiosFromPriceLiquidity(currentPrice);
     }
 
@@ -118,7 +134,7 @@ contract LookupTableTest is TestHelper {
     function test_PriceRangeSwap() public {
         // test range 0.5 - 2.5
         uint256 currentPrice = 0.5e6;
-        for (uint256 i; i < 200; i++) {
+        for (uint256 i;  i<200 ; i++) {
             pd = lookupTable.getRatiosFromPriceSwap(currentPrice);
             assertGe(pd.highPrice, currentPrice);
             assertLt(pd.lowPrice, currentPrice);
@@ -129,11 +145,10 @@ contract LookupTableTest is TestHelper {
     function test_PriceRangeLiq() public {
         // test range 0.5 - 2.5
         uint256 currentPrice = 0.5e6;
-        for (uint256 i; i < 200; i++) {
+        for (uint256 i;  i<200 ; i++) {
             pd = lookupTable.getRatiosFromPriceLiquidity(currentPrice);
             assertGe(pd.highPrice, currentPrice);
             assertLt(pd.lowPrice, currentPrice);
-            assertLt(pd.highPriceJ / pd.precision, 1e18);
             currentPrice += 0.01e6;
         }
     }