Link21 Transit Improvements #127
Conversation
multiply skim by 100, Fix OMX (double to float), add extra skims to _skim_properties, update current skim names, drive perception factors, walk time calculation
this got mixed up in resolving the conflicts when trying to bring the bart changes into develop.
this is to keep the resulting number of modes less than 30 (EMME restriction).
Making Link21 Changes Runnable
DavidOry
requested review from
FlaviaTsang,
i-am-sijia,
inrokevin and
lmz
as code owners
There was a problem hiding this comment.
Sync with @yueshuaing and get all the placeholders reconciled.
There was a problem hiding this comment.
Moved the working config to the config folder.
| transit_demand_file = "demand_matrices/transit/TAP_Demand_{set}_{period}_{iter}.omx" | ||
| # transit_demand_file = "demand_matrices/transit/TAP_Demand_{set}_{period}_{iter}.omx" | ||
| active_demand_file = "demand_matrices/active/nm_demand_{period}.omx" | ||
| transit_demand_file = "demand_matrices/transit/trn_demand_{period}.omx" #temp name format, add iteration? |
There was a problem hiding this comment.
Changed naming convention.
| highway_taz_ctramp_output_file = "ctramp_output/{mode_agg}_{period}_{mode}_{period}.omx" | ||
| highway_maz_ctramp_output_file = "ctramp_output/auto_{period}_MAZ_AUTO_{number}_{period}.omx" | ||
| transit_tap_ctramp_output_file = "ctramp_output/{mode_agg}_{period}_{mode}_TRN_{set}_{period}.omx" | ||
| transit_taz_ctramp_output_file = "ctramp_output/{mode_agg}_{period}_{mode}_TRN_{period}.omx" |
There was a problem hiding this comment.
Added reading in the trip lists to create the demand matrices in tm2py rather than the Java code.
| @@ -61,7 +81,46 @@ | |||
| [[household.mode_agg]] | |||
| name = "transit" | |||
| modes = ["KNRPRV", "KNRTNC", "PNR", "WLK"] | |||
|
|
|||
| [household.rideshare_mode_split] | |||
There was a problem hiding this comment.
Need all this to convert the CT-RAMP demand to vehicle trips
| effective_headway_source = "hdw" | ||
| initial_wait_perception_factor = 1.5 | ||
| transfer_wait_perception_factor = 3.0 | ||
| walk_perception_factor = 2.0 | ||
| initial_boarding_penalty = 10 | ||
| transfer_boarding_penalty = 10 | ||
| walk_perception_factor_cbd = 1.0 |
There was a problem hiding this comment.
Expose perception factors, add ability to have spatially-different perception factors
| if use_ccr: | ||
| with self.controller.emme_manager.logbook_trace("CCR related skims"): | ||
| self.skim_reliability_crowding_capacity(time_period, transit_class) | ||
| self.mask_above_max_transfers(time_period, transit_class) | ||
| self.mask_if_not_required_modes(time_period, transit_class) | ||
| #if congested_transit_assignment: |
There was a problem hiding this comment.
@arashasadabadi: delete old code
| "result": f'mf"{_tp_tclass}_XFERS"', | ||
| "expression": f'(mf"{_tp_tclass}_XFERS" - 1).max.0', | ||
| } | ||
| if ("PNR_TRN_WLK" in _tp_tclass) or ("WLK_TRN_PNR"in _tp_tclass): |
There was a problem hiding this comment.
@arashasadabadi: check that the UEC changes are not reducing the number of boardings twice.
| @@ -507,6 +536,161 @@ def _calc_total_ivt( | |||
| num_processors=self.controller.num_processors, | |||
| ) | |||
|
|
|||
| def skim_drive_walk( | |||
There was a problem hiding this comment.
Skim access/egress (TAP to TAZ)
| num_processors=self.controller.num_processors, | ||
| ) | ||
|
|
||
| def skim_penalty_toll( |
There was a problem hiding this comment.
Allow for skimming of a boarding time penalty, that can be set to zero for transfers.
| @@ -76,6 +79,28 @@ class ScenarioConfig(ConfigItem): | |||
| ] | |||
| EmptyString = Literal[""] | |||
|
|
|||
| @dataclass(frozen=True) | |||
| class WarmStartConfig(ConfigItem): | |||
There was a problem hiding this comment.
warm start infrastructure
What existing problem does the pull request solve and why should we include it?
Bring in the Link21 transit improvements, which need to be merged with the new tm2py architecture
What is the testing plan?
This will impact all tests
Demonstrate the code is solid by discussing how results are verified and covered by tests
Code formatting
Code should be PEP8 compliant before merging by running a package like
blackApplicable Issues
Please do not create a Pull Request without creating an issue first.
Closes #125
Issues List