Skip to content

Major cleanup

Compare
Choose a tag to compare
@fscottfoti fscottfoti released this 15 Mar 21:28

These are major changes which make up some code debt from the last release. This should clean up and document a great deal of functionality from the last Plan.

See #70

Here is a relatively complete list (but I might have missed one or two points)

  • left files on s3, but got rid of Makefile. Fetching files is now a mode of baus.py

  • Got rid of vagrant file

  • Got rid of data_regeneration scripts - will start soon on redoing these, but since they're preserved in the history no need to keep them in master

  • Got rid of qgis maps

  • Moved additional_units model to auxiliary_units model (renamed)

  • Commented all code and settings.yaml

  • Rewrote README for all these changes

  • Moved run.py to baus.py to have a more specific name

  • Reviewed scripts directory and added some description of what the scripts do (in the README) reviewed the scripts and got rid of those scripts we won't use again

  • Now have preprocessing mode of baus.py so deed restricted units don't get assigned on the fly (saves time)

  • Don't have baseyear simulation instead we write out base year summaries every time. We don't need to run the whole model system in the base year, and baus.py is modified to take care of this

  • Proportional jobs model assigns only to the correct types - there is still some work to do here

  • Homesales dataframe not required since redfin prices are assigned to buildings dataset

  • TAZ variable computations were somewhat sloppy before - they've been rewritten

  • use getopt in baus.py so now we have a pretty usage statement

  • double check all caching settings

  • set up travis to do pep8 and unit test checks - tests are modest at this point - I have a list of testing improvements to make

  • we don't use numbers for building types - they're not two letter characters - HS, HT, HM, etc