-
-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added partial media permission to android #1347
added partial media permission to android #1347
Conversation
…. Also set android project to use local interface
Could use some help with the changelog and the pubspec.yaml update as versioning in open source is new to me. Something to bear in mind is that if you grant partial permission Permission.photo comes back as PermissionStatus.permanentlyDenied. You could look into merging these two permissions however I believe when implementing them it would be better to check if either is true. |
…t use local path
I have tested this branch on Android simulator with following specifications:
But getting Minimum reproducible code :
|
@AnujLM that is correct, a new permission partialMediaAccess has been added. It could be that it instead should be incorporated into permission.photos and I can look into that. My first thought was that you would do something like if (permissions.photos || permissions.partialMediaAccess). |
@LulleBulle got your point, have checked with |
@AnujLM I have now baked it into the photos permission and it will return Limited if you select partial. Same with videos. The example app has an issue with not refreshing instantly that I don't know how to fix, scroll down and up again and it should return correctly. Given that ist just an exmaple app I am not entirely sure that there's not some bugs with it. I believe the desired use of it is all depending on user case. Let me know what you think. |
@mvanbeusekom could you take a look at this? |
@LulleBulle please add him in reviewers section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LulleBulle,
Thank you for this contribution. I realize this is a bit late, however I was wondering if you could:
- Rollback the changes to the
permission_handler_platform_interface
package (these should be submitted as a separate PR). - Update the
version
tag in thepubspec.yaml
file. - Update the
CHANGELOG.md
file mentioning the changes made.
Hi @mvanbeusekom , |
It has been taken care of. Let me know if it is satisfactory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for this contribution.
@mvanbeusekom, could you please let us know when you plan to release the next version of Thank you! |
I updated the dependency in my app, but still it is not working. the permissions.photos.request() permission is still returning "PermissionStatus.denied" upon selecting limited access. versions using:- |
@QL-Uday I checked versions: There is a workaround. So you can call
|
I made fix in PR #1362 |
* added partial media permission to android and bumped compileSDK to 34. Also set android project to use local interface * updated unit test with total permissions count + reset pubspec to not use local path * baked the partial permission into original photo * removed the partial permission as its baked into photos now * added new limited to videos as well * fixed format * Versioning + reset platform_interface
Adds support for partial image permission with android. Fixes #1156
List at least one fixed issue.
Pre-launch Checklist
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.md
to add a description of the change.///
).main
.dart format .
and committed any changes.flutter analyze
and fixed any errors.