Report ignoreBatteryOptimizations permission correctly #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeroenWeener
suggested changes
Oct 23, 2023
|
|
||
| if (requestCode == PermissionConstants.PERMISSION_CODE_IGNORE_BATTERY_OPTIMIZATIONS) { | ||
| permission = PermissionConstants.PERMISSION_GROUP_IGNORE_BATTERY_OPTIMIZATIONS; | ||
|
|
||
| if (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) { | ||
| return false; |
There was a problem hiding this comment.
Do we want to report false or true when the device runs a version below Marshmallow? Doze and App Stand-by were not introduced until Marshmallow. It might make sense to return this as true from a developer's perspective, as to indicate that the application is not subjected to battery optimizations.
There was a problem hiding this comment.
That is a good point, I will update the code
There was a problem hiding this comment.
This is probably also the case for the logic that handles just checking the status of the permission
JeroenWeener
approved these changes
Oct 23, 2023
JeroenWeener
pushed a commit
to JeroenWeener/flutter-permission-handler
that referenced
this pull request
Oct 26, 2023
* Report ignoreBatteryOptimizations permission correctly * Report restricted status pre-marshmallow devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the
ignoreBatteryOptimizationsreports a denied status when requesting permission and the user granted permission.Solves #1191
Pre-launch Checklist
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.mdto add a description of the change.///).main.dart format .and committed any changes.flutter analyzeand fixed any errors.