Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Permission.calendarReadOnly and Permission.calendarFullAccess #1189

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

JeroenWeener
Copy link
Contributor

Implements the Permission.calendarReadOnly and Permission.calendarFullAccess permissions.

The current architecture does not support the way Android deals with calendar permissions very well. As a refactor that removes almost all Java code is in the works, we decided not to care too much about the code quality.

Closes #1182.

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeroenWeener JeroenWeener merged commit 627daa9 into Baseflow:main Oct 13, 2023
@JeroenWeener JeroenWeener deleted the enhancement/1182 branch October 13, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Split calendar permission into read-only and full access (Android)
2 participants