-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recall previous inputs with up/down arrows #1
base: master
Are you sure you want to change the base?
Conversation
865682b
to
87e69cb
Compare
1a391c1
to
ffcd692
Compare
f252a9d
to
1a3d347
Compare
After implementing my own history recall feature in lDebug I compared yours in this PR to mine. Differences:
Similarities also include rejecting empty lines and those duplicating the prior line. |
Correction: It appears your patch does away with the interrupt 21h service 0Ah call entirely and always uses interrupt 16h to read input. In my implementation DOS application terminal input is still done with the DOS service by default, which means the debugger's line history is not available. (I do enter received lines into the history buffer regardless.) And if |
97b11c5
to
1946d78
Compare
8ace82c
to
205925d
Compare
This patch implements recalling previously typed commands with the up and down arrow keys, as is common in most shells and other debuggers.
Binary size is increased by 244 bytes and memory requirement by 516 bytes (adjustable with
LINE_HISTORY_LEN
).