Small fixes #16
Small fixes #16
Conversation
|
What does this PR do? |
|
It basically collects all the small fixes that don't deserve their own PR (IMO). As you can see in the commits, this can include: fixing small to-dos, adding trailing semicolons, clean up small unnecessary+unused functions, ... So this PR is basically intended to stay open and collect all these small adjustments. Would you prefer to split these fixes into seperate commits/PRs? |
|
Yes, just split them by scope/topic. And I merge them. Also don't hesitate to describe your changes in the commit messages. ;) |
|
I am still feeling a bit insecure about how to split it - do you want different PR's ? or only seperate commits? I don't feel very well building commits with single line changes. |
|
Yeah, please just split them by concern. If you fulfill a concern with a single-line change, then that is a valid commit and PR. One concern, one PR. You may split a PR into multiple commits if they are functionally distinct. Example: The concern could be "revamp action interface". The different commits could be "revamp untyped actions", "revamp typed actions", ... Neither PRs nor commits cost any money. Just make new ones. But you only have about 75 characters to motivate your commit. If you put too many unrelated changes into a single commit., nobody will understand why a particular change happened there in the long run, because the commit summary likely won't tell them. |
|
To lighten your workload. You could just further describe, what changes you did in the 3 commits of this PR, by extending their commit messages. For instance, I have no idea what the "style" fixes actually do functionally. Additionally, please make sure that a commit with the summary "style fixes" actually does not change any semantics. Not even slightly. Nobody suspects that in a commit with that summary. So this would be a clear differentiator to split the commit further. |
No description provided.