Lussac v2.0 b5 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update version to 'dev'
Testing a new way to remove bad units (i.e. merged, mua) in the `merge_sortings` module.
All filtering done is now a Gaussian filter Switched from `amplitude_std` to `sd_ratio`
Fixed a bug where params `{}` would not run the PCA or spike amplitudes.
Fixed a bug in the logs of `merge_sortings.clean_edges` Fixed a bug in the plot logs
Improved the merging process in `merge_sortings` Fixed a crash with sortings containing no units or units with no spikes. Improved memory usage overall. Heavy pipelines are now much faster.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
- Coverage 99.75% 99.36% -0.40%
==========================================
Files 24 23 -1
Lines 1632 1571 -61
==========================================
- Hits 1628 1561 -67
- Misses 4 10 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.