Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

236 variable definition formatter #243

Merged
merged 38 commits into from
Oct 18, 2024
Merged

236 variable definition formatter #243

merged 38 commits into from
Oct 18, 2024

Conversation

gustason
Copy link
Collaborator

@gustason gustason commented Oct 2, 2024

No description provided.

@gustason gustason requested a review from PauliusKu October 2, 2024 07:12
@gustason gustason linked an issue Oct 2, 2024 that may be closed by this pull request
Variable Definition formatter #236
Closed
gmickus added 3 commits October 2, 2024 10:13
Merge remote-tracking branch 'origin' into 236-variable-definition-fo…
825b926 
…rmatter

# Conflicts:
#	package.json
#	src/model/SyntaxNodeType.ts
#	src/v2/formatterFramework/enableFormatterDecorators.ts
Implement formatter for procedure parameters
2d96cae
Fix import
6c035cd
@gustason
Copy link
Collaborator Author

gustason commented Oct 2, 2024

Fixes #239 as well.

PauliusKu
PauliusKu reviewed Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@PauliusKu PauliusKu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see SyntaxNodeType.Error handling in switch statement? I think we should use them in every node type switch throughout the code.

@PauliusKu
Copy link
Collaborator

@gustason ?

@gustason
Copy link
Collaborator Author

I don't see SyntaxNodeType.Error handling in switch statement? I think we should use them in every node type switch throughout the code.

I will fix that today for all PRs.

@PauliusKu PauliusKu merged commit 10cc25b into develop Oct 18, 2024
3 checks passed
@gustason gustason mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PauliusKu PauliusKu PauliusKu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variable Definition formatter
3 participants
@gustason @PauliusKu @SSaulenas