49 expression formatter #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 27, 2024 09:53
# Conflicts: # package.json # resources/functionalTests/define-inClass/input.p # resources/functionalTests/define-inClass/target.p # resources/functionalTests/define-inFunction/input.p # resources/functionalTests/define-inFunction/target.p # resources/functionalTests/define/16inClass/input.p # resources/functionalTests/define/16inClass/target.p # resources/functionalTests/define/16inFunction/input.p # resources/functionalTests/define/16inFunction/target.p # resources/functionalTests/define/define-inClass/input.p # resources/functionalTests/define/define-inClass/target.p # resources/functionalTests/define/define-inFunction/input.p # resources/functionalTests/define/define-inFunction/target.p # src/v2/formatterFramework/FormatterHelper.ts # src/v2/formatterFramework/enableFormatterDecorators.ts
|
Now 19 tests do not pass because of the tests for assign and the bug in #147. Need to turn off the expression formatted for all the assign tests. |
|
Now only 1 failing test due to #147. |
|
@gustason can you fix merge conflicts? Also, is this one blocking issue critical for us? Maybe we can proceed with this formatter. |
added 11 commits
September 4, 2024 10:07
# Conflicts: # src/model/SyntaxNodeType.ts
# Conflicts: # package.json # src/model/SyntaxNodeType.ts # src/v2/formatterFramework/enableFormatterDecorators.ts
|
I see that tests are not passing. @gustason please check, maybe settings in testing folder are not up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge!
Currently, 37 tests do not pass because of the bug in #116.