-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ECLP / Gyro Fee Split #266
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any kind of rerouting should be apparent in the config files in multisig ops and somewhat human readable.
I think the first step is to understand at what level gyro wants to route. Then figure out a configuration, then build code to process it. Also need to figure out when/where to take these fees. Do we take them off the top, and then split the rest based on our ratio, or something different?
I would imagine the fee override config to look something like this, or fit in this file.
We could basically add builder_fee_percent, and builder_fee_address(maybe by chain) as options here.
What we more likely want to do is filter based on factory type, so another change could be creating a factory_incentives_override.json and doing the same thing but accepting factories as inputs instead of pool_ids.
Note that this config file should actually also have name or symbol in it. We don't need to ever read it in the code, but it's much more readable with some metadata.
I think it makes sense to table this until the spec is more clear, but in general any changes to the economic rules of the code should be expressed in configuration in multisig ops and be approved/managed by governance.
Don't action this work until we have a spec. Food for thought about future PRs.
#264