Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permissions Fix #502

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Permissions Fix #502

merged 2 commits into from
Sep 11, 2023

Conversation

Tritium-VLK
Copy link
Member

Swaps permissions to be properly set.

setSwapFeePercentage 0x32725667b078898f78f53e59f45eb1837b34a9469dbe36f9270b674247b23abf is permitted to the LM Multisig 0x326A7778DB9B741Cb2acA0DE07b9402C7685dAc6.

enableRecoveryMode 0x8ceae9d0f076b4b0c529529f6bf11832835b93b533445c655b840015f7025e50 is permitted to the PoolRecoveryHelper 0x3b8cA519122CdD8efb272b0D3085453404B25bD0

@Zen-Maxi
Permissions Fix
bb685a0 
Swaps permissions to be properly set.

setSwapFeePercentage 0x32725667b078898f78f53e59f45eb1837b34a9469dbe36f9270b674247b23abf is permitted to the LM Multisig 0x326A7778DB9B741Cb2acA0DE07b9402C7685dAc6.

enableRecoveryMode 0x8ceae9d0f076b4b0c529529f6bf11832835b93b533445c655b840015f7025e50 is permitted to the PoolRecoveryHelper 0x3b8cA519122CdD8efb272b0D3085453404B25bD0
@Tritium-VLK Tritium-VLK changed the base branch from main to gha-payload-merge September 11, 2023 19:34
@github-actions
Copy link
Contributor

BIP validation results for file BIPs/2023-W36/BIP-422.json:
Commit: bb685a06c6df145f9efd0102370d9d68d2e6834c

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

@github-actions
Copy link
Contributor

File name: BIPs/2023-W36/BIP-422.json
COMMIT: bb685a06c6df145f9efd0102370d9d68d2e6834c
CHAIN(S): avalanche

+-----------------------+--------------------------------------------------+--------------------------------------------+----------------------------------------------------------------------+--------------------------------------------------------------------+---------+------------+
| function              | caller_name                                      | caller_address                             | fx_paths                                                             | action_ids                                                         | bip     |   tx_index |
+=======================+==================================================+============================================+======================================================================+====================================================================+=========+============+
| Authorizer/grantRole  | multisigs/fees                                   | 0x326A7778DB9B741Cb2acA0DE07b9402C7685dAc6 | 20230320-weighted-pool-v4/WeightedPool/setSwapFeePercentage(uint256) | 0x32725667b078898f78f53e59f45eb1837b34a9469dbe36f9270b674247b23abf | BIP-422 |          0 |
+-----------------------+--------------------------------------------------+--------------------------------------------+----------------------------------------------------------------------+--------------------------------------------------------------------+---------+------------+
| Authorizer/grantRole  | 20221123-pool-recovery-helper/PoolRecoveryHelper | 0x3b8cA519122CdD8efb272b0D3085453404B25bD0 | 20230320-weighted-pool-v4/WeightedPool/enableRecoveryMode()          | 0x8ceae9d0f076b4b0c529529f6bf11832835b93b533445c655b840015f7025e50 | BIP-422 |          1 |
+-----------------------+--------------------------------------------------+--------------------------------------------+----------------------------------------------------------------------+--------------------------------------------------------------------+---------+------------+
| Authorizer/grantRoles | multisigs/emergency                              | 0x308f8d3536261C32c97D2f85ddc357f5cCdF33F0 | 20230320-weighted-pool-v4/WeightedPool/enableRecoveryMode()          | 0x8ceae9d0f076b4b0c529529f6bf11832835b93b533445c655b840015f7025e50 | BIP-422 |          2 |
|                       |                                                  |                                            | 20230320-weighted-pool-v4/WeightedPoolFactory/disable()              | 0xd7acda26118b9ff06dd8526d0197d58c0c7ed83074be6d915bff2db42b5581ae |         |            |
|                       |                                                  |                                            | 20230320-weighted-pool-v4/WeightedPool/pause()                       | 0xb9c5dbd31b49d898a12157d05b5f59e61b30533c20fe266652c1017837135f0c |         |            |
+-----------------------+--------------------------------------------------+--------------------------------------------+----------------------------------------------------------------------+--------------------------------------------------------------------+---------+------------+

@Tritium-VLK Tritium-VLK merged commit f86a1e4 into gha-payload-merge Sep 11, 2023
@Tritium-VLK Tritium-VLK deleted the BIP-422-weighted-pool-permissions-Avalanche branch September 30, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tritium-VLK @Zen-Maxi