[BIP-748] Permissions Policy Update Request #5 (Ethereum) #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FILENAME:
|
… reports) + reformat JSON
There was a problem hiding this comment.
confirming that this change, in comparison to my previous review:
- removes
stkgho.approve(maverick_router_v2) - removes
gho.approve(maverick_router_v2) - removes
maverick_router_v2.inputSingleWithTickLimit - removes
aave_v3_pool.swapBorrowRateMode(gho, *) - adds
gyd.approve(sgyd)
@dk57 can you rename the json filename to begin with [BIP-748]? then we are ready to go for snapshot!
gosuto-inzasheru
changed the title
… reports) + reformat JSON
gosuto-inzasheru
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
report from our side was generated successfully, but is too big to be posted as a comment. see https://github.com/BalancerMaxis/multisig-ops/blob/1e5f1d23b3a476694917a4f874392f8332f47297/BIPs/2024-W52/%5BBIP-748%5D%20Permissions%20Policy%20Update%20Request%20%235%20Revised.report.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permissions page: https://roles.gnosisguild.org/permissions/eth/NfctZijIdCdch4Wvjsp4OPQHuFbclUBGqULuE8bI
Permissions diff page: https://roles.gnosisguild.org/eth:0x13c61a25DB73e7a94a244bD2205aDba8b4a60F4a/roles/MANAGER/diff/NfctZijIdCdch4Wvjsp4OPQHuFbclUBGqULuE8bI
@gosuto-inzasheru The easiest way to compare the original PUR policy you already reviewed and the new one is by checking the diff of the diffs:
https://roles.gnosisguild.org/permissions/eth/6WhgTGie6QoelTwqaE6z8h0MqZa6UOkyZcwJif5si[…]NfctZijIdCdch4Wvjsp4OPQHuFbclUBGqULuE8bI?annotations=false
I also added the approval for sGYD we didn't include in the GYD Proposal