Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reth-weeth-and-sfrxeth-wsteth-reth pool fee update #1588

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

zekraken-bot
Copy link
Collaborator

  1. 2nd attempt of reth-weeth update, solver didn't reset the last one properly

  2. setting sfrxETH-wstETH-rETH pool that is in recovery to 2bps in effort to migrate people to pool not in recovery, also test what happens to volume and fees since the TVL is close to the same pool set at 1bp. however, to note the amp factor between the two pools is very different, so test isn't really that great.

>2nd attempt of reth-weeth update, solver didn't reset the last one properly

>setting sfrxETH-wstETH-rETH pool that is in recovery to 2bps in effort to migrate people to pool not in recovery, also test what happens to volume and fees since the TVL is close to the same pool set at 1bp. however, to note the amp factor between the two pools is very different, so test isn't really that great.
Copy link
Contributor

FILENAME: MaxiOps/PoolParameterChanges/PoolSwapFeeChanges/Mainnet/reth-weeth-fee-update-4bp-1bp_part2.json
COMMIT: 4a75db2687f781c582f1a8c6266728018651964d

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified

FILENAME: MaxiOps/PoolParameterChanges/PoolSwapFeeChanges/Mainnet/sfrxETH-rETH-wstETH-fee-update-less-than-1-bp-to-2bps.json
COMMIT: 4a75db2687f781c582f1a8c6266728018651964d

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified

Copy link
Contributor

FILENAME: MaxiOps/PoolParameterChanges/PoolSwapFeeChanges/Mainnet/reth-weeth-fee-update-4bp-1bp_part2.json
MULTISIG: multisigs/lm (mainnet:0xc38c5f97B34E175FFd35407fc91a937300E33860)
COMMIT: 4a75db2687f781c582f1a8c6266728018651964d
CHAIN(S): mainnet
TENDERLY: 🟩 SUCCESS

+----------------------+--------------------------------------------------------------------+-------+--------------------------+------------+----------+
| fx_name              | to                                                                 | value | inputs                   | bip_number | tx_index |
+----------------------+--------------------------------------------------------------------+-------+--------------------------+------------+----------+
| setSwapFeePercentage | 0x05ff47AFADa98a98982113758878F9A8B9FddA0a (pools/weETH/rETH-05ff) | 0     | {                        | N/A        |   N/A    |
|                      |                                                                    |       |   "swapFeePercentage": [ |            |          |
|                      |                                                                    |       |     "100000000000000"    |            |          |
|                      |                                                                    |       |   ]                      |            |          |
|                      |                                                                    |       | }                        |            |          |
+----------------------+--------------------------------------------------------------------+-------+--------------------------+------------+----------+

FILENAME: MaxiOps/PoolParameterChanges/PoolSwapFeeChanges/Mainnet/sfrxETH-rETH-wstETH-fee-update-less-than-1-bp-to-2bps.json
MULTISIG: multisigs/feeManager (mainnet:0xf4A80929163C5179Ca042E1B292F5EFBBE3D89e6)
COMMIT: 4a75db2687f781c582f1a8c6266728018651964d
CHAIN(S): mainnet
TENDERLY: 🟩 SUCCESS

+-------------+-------------------------------------------------------------------------+-------+---------------------------------------------------------------------------------------+------------+----------+
| fx_name     | to                                                                      | value | inputs                                                                                | bip_number | tx_index |
+-------------+-------------------------------------------------------------------------+-------+---------------------------------------------------------------------------------------+------------+----------+
| setSwapFees | 0xE4a8ed6c1D8d048bD29A00946BFcf2DB10E7923B (gauntlet/GauntletFeeSetter) | 0     | {                                                                                     | N/A        |   N/A    |
|             |                                                                         |       |   "addresses": [                                                                      |            |          |
|             |                                                                         |       |     "0x5aEe1e99fE86960377DE9f88689616916D5DcaBe (pools/wstETH-rETH-sfrxETH-BPT-5aee)" |            |          |
|             |                                                                         |       |   ],                                                                                  |            |          |
|             |                                                                         |       |   "fees": [                                                                           |            |          |
|             |                                                                         |       |     "200000000000000"                                                                 |            |          |
|             |                                                                         |       |   ]                                                                                   |            |          |
|             |                                                                         |       | }                                                                                     |            |          |
+-------------+-------------------------------------------------------------------------+-------+---------------------------------------------------------------------------------------+------------+----------+

@zekraken-bot zekraken-bot merged commit 5db1750 into main Dec 17, 2024
2 checks passed
@zekraken-bot zekraken-bot deleted the zekraken-bot-patch-1 branch December 17, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants