Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add v3 global fees payload json #1573

Merged
merged 6 commits into from
Dec 11, 2024
Merged

chore: add v3 global fees payload json #1573

merged 6 commits into from
Dec 11, 2024

Conversation

gosuto-inzasheru
Copy link
Collaborator

@gosuto-inzasheru gosuto-inzasheru commented Dec 10, 2024 •
edited
Loading

as per bip734

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited
Loading

FILENAME: MaxiOps/PoolParameterChanges/v3-global-fees-gnosis.json
COMMIT: b01d77f5ee76bd8b7c98f72ec97ebc5be3f15057

Validator Result
validate_contains_msig ✅
validate_msig_in_address_book ✅
validate_chain_specified ✅

FILENAME: MaxiOps/PoolParameterChanges/v3-global-fees.json
COMMIT: b01d77f5ee76bd8b7c98f72ec97ebc5be3f15057

Validator Result
validate_contains_msig ✅
validate_msig_in_address_book ✅
validate_chain_specified ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited
Loading

FILENAME: MaxiOps/PoolParameterChanges/v3-global-fees-gnosis.json
MULTISIG: multisigs/maxi_omni (gnosis:0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e)
COMMIT: b01d77f5ee76bd8b7c98f72ec97ebc5be3f15057
CHAIN(S): gnosis
TENDERLY: 🟩 SUCCESS

+-------------------------------------+--------------------------------------------------------------------------------------+-------+--------------------------------------+------------+----------+
| fx_name                             | to                                                                                   | value | inputs                               | bip_number | tx_index |
+-------------------------------------+--------------------------------------------------------------------------------------+-------+--------------------------------------+------------+----------+
| setGlobalProtocolSwapFeePercentage  | 0xa731C23D7c95436Baaae9D52782f966E1ed07cc8 (20241204-v3-vault/ProtocolFeeController) | 0     | {                                    | N/A        |   N/A    |
|                                     |                                                                                      |       |   "newProtocolSwapFeePercentage": [  |            |          |
|                                     |                                                                                      |       |     "500000000000000000"             |            |          |
|                                     |                                                                                      |       |   ]                                  |            |          |
|                                     |                                                                                      |       | }                                    |            |          |
| setGlobalProtocolYieldFeePercentage | 0xa731C23D7c95436Baaae9D52782f966E1ed07cc8 (20241204-v3-vault/ProtocolFeeController) | 0     | {                                    | N/A        |   N/A    |
|                                     |                                                                                      |       |   "newProtocolYieldFeePercentage": [ |            |          |
|                                     |                                                                                      |       |     "100000000000000000"             |            |          |
|                                     |                                                                                      |       |   ]                                  |            |          |
|                                     |                                                                                      |       | }                                    |            |          |
+-------------------------------------+--------------------------------------------------------------------------------------+-------+--------------------------------------+------------+----------+

FILENAME: MaxiOps/PoolParameterChanges/v3-global-fees.json
MULTISIG: multisigs/maxi_omni (mainnet:0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e)
COMMIT: b01d77f5ee76bd8b7c98f72ec97ebc5be3f15057
CHAIN(S): mainnet
TENDERLY: 🟩 SUCCESS

+-------------------------------------+--------------------------------------------------------------------------------------+-------+--------------------------------------+------------+----------+
| fx_name                             | to                                                                                   | value | inputs                               | bip_number | tx_index |
+-------------------------------------+--------------------------------------------------------------------------------------+-------+--------------------------------------+------------+----------+
| setGlobalProtocolSwapFeePercentage  | 0xa731C23D7c95436Baaae9D52782f966E1ed07cc8 (20241204-v3-vault/ProtocolFeeController) | 0     | {                                    | N/A        |   N/A    |
|                                     |                                                                                      |       |   "newProtocolSwapFeePercentage": [  |            |          |
|                                     |                                                                                      |       |     "500000000000000000"             |            |          |
|                                     |                                                                                      |       |   ]                                  |            |          |
|                                     |                                                                                      |       | }                                    |            |          |
| setGlobalProtocolYieldFeePercentage | 0xa731C23D7c95436Baaae9D52782f966E1ed07cc8 (20241204-v3-vault/ProtocolFeeController) | 0     | {                                    | N/A        |   N/A    |
|                                     |                                                                                      |       |   "newProtocolYieldFeePercentage": [ |            |          |
|                                     |                                                                                      |       |     "100000000000000000"             |            |          |
|                                     |                                                                                      |       |   ]                                  |            |          |
|                                     |                                                                                      |       | }                                    |            |          |
+-------------------------------------+--------------------------------------------------------------------------------------+-------+--------------------------------------+------------+----------+

@gosuto-inzasheru gosuto-inzasheru marked this pull request as ready for review December 11, 2024 00:35
Tritium-VLK
Tritium-VLK approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@Tritium-VLK Tritium-VLK left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BIP-734 specifies 50% on swap 10% on yield for V3. It specifies that technical specs will be provided in a future BIP.

BIP-741 does not explicitly specify that the Maxis should set these changes, but does authorize them to set fees.

It seems reasonable to conclude that this is:

  1. At the wishes of governance
  2. For the Maxis to technically specify
  3. Technically correct according to BIP-734

MaxiOps/PoolParameterChanges/v3-global-fees-gnosis.json
"payable": false
},
"contractInputsValues": {
"newProtocolSwapFeePercentage": "500000000000000000"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

500000000000000000/1e18 = 0.5 or 50% fees on swap

MaxiOps/PoolParameterChanges/v3-global-fees-gnosis.json
"payable": false
},
"contractInputsValues": {
"newProtocolYieldFeePercentage": "100000000000000000"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100000000000000000/1e18 = 0.1 or 10% fees on yield.

MaxiOps/PoolParameterChanges/v3-global-fees.json
"payable": false
},
"contractInputsValues": {
"newProtocolSwapFeePercentage": "500000000000000000"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

MaxiOps/PoolParameterChanges/v3-global-fees.json
"payable": false
},
"contractInputsValues": {
"newProtocolYieldFeePercentage": "100000000000000000"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@gosuto-inzasheru gosuto-inzasheru merged commit fa96117 into main Dec 11, 2024
2 checks passed
@gosuto-inzasheru gosuto-inzasheru deleted the chore/set-v3-global-fees branch December 11, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tritium-VLK Tritium-VLK Tritium-VLK approved these changes

@Zen-Maxi Zen-Maxi Awaiting requested review from Zen-Maxi

@Xeonus Xeonus Awaiting requested review from Xeonus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gosuto-inzasheru @Tritium-VLK