Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BIP-739]-Delegate-Gyroscope-GGU-to-DAO-Participants #1545

Merged
merged 5 commits into from
Dec 9, 2024
Merged

[BIP-739]-Delegate-Gyroscope-GGU-to-DAO-Participants #1545

merged 5 commits into from
Dec 9, 2024

Conversation

Zen-Maxi
Copy link
Collaborator

@Zen-Maxi Zen-Maxi commented Dec 4, 2024

Zen-Maxi added a commit to BalancerMaxis/bal_addresses that referenced this pull request Dec 4, 2024
@Zen-Maxi
Update-for-Gyro-Delegation
98d52ef 
Adds AssociatedDAOVault, Zen Dragon EOA, and Naly EOA to address list. Feel free to move delegate EOAs elsewhere if cleaner. Mainly want reporting to run properly. I don’t think these addresses exist on any multisigs in out system to be clear though.

BalancerMaxis/multisig-ops#1545
@Zen-Maxi Zen-Maxi mentioned this pull request Dec 4, 2024
Merged
@Zen-Maxi
Copy link
Collaborator Author

Zen-Maxi commented Dec 4, 2024

Pending PR for bal_addresses update: BalancerMaxis/bal_addresses#536

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024 •
edited
Loading

FILENAME: BIPs/2024-W50/[BIP-XXX]-Delegate-Gyroscope-GGU-to-DAO-Participants.json
COMMIT: 739f48f66ded90e0bcad7022bbec18eba4ad1dce

Validator Result
validate_contains_msig ✅
validate_msig_in_address_book ✅
validate_chain_specified ✅
validate_file_has_bip ❌ (No BIP number found in file path BIPs/2024-W50/[BIP-XXX]-Delegate-Gyroscope-GGU-to-DAO-Participants.json)
validate_path_has_weekly_dir ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024 •
edited
Loading

FILENAME: BIPs/2024-W50/[BIP-XXX]-Delegate-Gyroscope-GGU-to-DAO-Participants.json
MULTISIG: multisigs/dao (mainnet:0x10A19e7eE7d7F8a52822f6817de8ea18204F2e4f)
COMMIT: 739f48f66ded90e0bcad7022bbec18eba4ad1dce
CHAIN(S): mainnet
TENDERLY: 🟩 SUCCESS

+--------------+----------------------------------------------------------------------+-------+-----------------------------------------------------------------------------+------------+----------+
| fx_name      | to                                                                   | value | inputs                                                                      | bip_number | tx_index |
+--------------+----------------------------------------------------------------------+-------+-----------------------------------------------------------------------------+------------+----------+
| delegateVote | 0xA2321E23B3060e160195E138b62F8498546B0247 (gyro/AssociatedDAOVault) | 0     | {                                                                           | N/A        |   N/A    |
|              |                                                                      |       |   "_delegate": [                                                            |            |          |
|              |                                                                      |       |     "0x25B70c8050B7e327Ce62CfD80A0C60cCcf057Fa6 (gyro/zen_dragon_delegate)" |            |          |
|              |                                                                      |       |   ],                                                                        |            |          |
|              |                                                                      |       |   "_amount": [                                                              |            |          |
|              |                                                                      |       |     "raw:20, 18 decimals:2E-17, 6 decimals: 0.00002"                        |            |          |
|              |                                                                      |       |   ]                                                                         |            |          |
|              |                                                                      |       | }                                                                           |            |          |
| delegateVote | 0xA2321E23B3060e160195E138b62F8498546B0247 (gyro/AssociatedDAOVault) | 0     | {                                                                           | N/A        |   N/A    |
|              |                                                                      |       |   "_delegate": [                                                            |            |          |
|              |                                                                      |       |     "0x9f74662aD05840Ba35d111930501c617920dD68e (N/A)"                      |            |          |
|              |                                                                      |       |   ],                                                                        |            |          |
|              |                                                                      |       |   "_amount": [                                                              |            |          |
|              |                                                                      |       |     "raw:20, 18 decimals:2E-17, 6 decimals: 0.00002"                        |            |          |
|              |                                                                      |       |   ]                                                                         |            |          |
|              |                                                                      |       | }                                                                           |            |          |
| delegateVote | 0xA2321E23B3060e160195E138b62F8498546B0247 (gyro/AssociatedDAOVault) | 0     | {                                                                           | N/A        |   N/A    |
|              |                                                                      |       |   "_delegate": [                                                            |            |          |
|              |                                                                      |       |     "0x29430750d7c3Ff58c9615490485deA50bdFD15f7 (gyro/defi_naly_delegate)"  |            |          |
|              |                                                                      |       |   ],                                                                        |            |          |
|              |                                                                      |       |   "_amount": [                                                              |            |          |
|              |                                                                      |       |     "raw:20, 18 decimals:2E-17, 6 decimals: 0.00002"                        |            |          |
|              |                                                                      |       |   ]                                                                         |            |          |
|              |                                                                      |       | }                                                                           |            |          |
+--------------+----------------------------------------------------------------------+-------+-----------------------------------------------------------------------------+------------+----------+

@Xeonus
Copy link
Collaborator

Xeonus commented Dec 5, 2024

@Zen-Maxi payload is wrong, need veballer.eth as delegate, not defilytica.eth!

Xeonus
Xeonus requested changes Dec 5, 2024
View reviewed changes
BIPs/2024-W50/[BIP-XXX]-Delegate-Gyroscope-GGU-to-DAO-Participants.json Outdated
"payable": false
},
"contractInputsValues": {
"_delegate": "0x99AfD53f807766A8B98400B0C785E500c041F32B",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to veballer.eth, thanks

@Zen-Maxi Zen-Maxi changed the title [BIP-XXX]-Delegate-Gyroscope-GGU-to-DAO-Participants [BIP-739]-Delegate-Gyroscope-GGU-to-DAO-Participants Dec 5, 2024
Xeonus
Xeonus approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@Xeonus Xeonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has correct signer set now, incl. 0x9f74662aD05840Ba35d111930501c617920dD68e - veballer.eth

@gosuto-inzasheru gosuto-inzasheru merged commit 0a0d92b into main Dec 9, 2024
2 checks passed
@gosuto-inzasheru gosuto-inzasheru deleted the BIP-XXX-Delegate-Gyroscope-GGU-to-DAO-Participants branch December 9, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xeonus Xeonus Xeonus approved these changes

@gosuto-inzasheru gosuto-inzasheru Awaiting requested review from gosuto-inzasheru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zen-Maxi @Xeonus @gosuto-inzasheru