simulate actions of vote.py in review_votes.py #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalbrekt85
changed the title
|
can you add |
… reports) + reformat JSON
vLAURA Votes ReviewCSV file: Allocation Check
Snapshot Votes Check
Vote PreparationSuccessfully simulated vote preparation ✅ Vote Summary
✅ All checks passed! |
good idea, added in ba1ba1b |
@gosuto-inzasheru temporarily added votes from last round to this branch to test ^^^ also updated to use the new max_omni label |
gosuto-inzasheru
approved these changes
Dec 4, 2024
|
Very nice indeed! Great work @jalbrekt85 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1517 - review_vote.py now simulates actions of vote.py, mainly parsing the vote csv and generating the EIP712 payload/message hash