Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USDC-Injector-Reward-adds-Rocketpool #1485

Merged
merged 2 commits into from
Oct 31, 2024
Merged

USDC-Injector-Reward-adds-Rocketpool #1485

merged 2 commits into from
Oct 31, 2024

Conversation

Zen-Maxi
Copy link
Collaborator

Adds USDC as a reward token for the respective injector to distribute to each rETH/wETH pool per Rocketpools request.

https://docs.google.com/spreadsheets/d/1oXztVRUMJlXKEcT8giQcls7ZJxEk45BA2LsSpq3qeK4/edit?gid=1846072370#gid=1846072370

@Zen-Maxi
USDC-Injector-Reward-adds-Rocketpool
49038dd 
Adds USDC as a reward token for the respective injector to distribute to each rETH/wETH pool per Rocketpools request.

https://docs.google.com/spreadsheets/d/1oXztVRUMJlXKEcT8giQcls7ZJxEk45BA2LsSpq3qeK4/edit?gid=1846072370#gid=1846072370
@Zen-Maxi Zen-Maxi enabled auto-merge October 30, 2024 20:23
@github-actions GitHub Actions
Copy link
Contributor

FILENAME: MaxiOps/add_rewards/arbitrum/USDC-Injector-rETH-wETH.json
COMMIT: 49038dd35f08299cf0734f7f44e58465cc9f5843

Validator Result
validate_contains_msig ✅
validate_msig_in_address_book ✅
validate_chain_specified ✅
validate_file_has_bip ❌ (No BIP number found in file path MaxiOps/add_rewards/arbitrum/USDC-Injector-rETH-wETH.json)
validate_path_has_weekly_dir ❌ (File MaxiOps/add_rewards/arbitrum/USDC-Injector-rETH-wETH.json has has no YYYY-W## in path)

FILENAME: MaxiOps/add_rewards/base/USDC-Injector-rETH-wETH.json
COMMIT: 49038dd35f08299cf0734f7f44e58465cc9f5843

Validator Result
validate_contains_msig ✅
validate_msig_in_address_book ✅
validate_chain_specified ✅
validate_file_has_bip ❌ (No BIP number found in file path MaxiOps/add_rewards/base/USDC-Injector-rETH-wETH.json)
validate_path_has_weekly_dir ❌ (File MaxiOps/add_rewards/base/USDC-Injector-rETH-wETH.json has has no YYYY-W## in path)

FILENAME: MaxiOps/add_rewards/optimism/USDC-Injector-rETH-wETH.json
COMMIT: 49038dd35f08299cf0734f7f44e58465cc9f5843

Validator Result
validate_contains_msig ✅
validate_msig_in_address_book ✅
validate_chain_specified ✅
validate_file_has_bip ❌ (No BIP number found in file path MaxiOps/add_rewards/optimism/USDC-Injector-rETH-wETH.json)
validate_path_has_weekly_dir ❌ (File MaxiOps/add_rewards/optimism/USDC-Injector-rETH-wETH.json has has no YYYY-W## in path)

@github-actions GitHub Actions
Copy link
Contributor

FILENAME: MaxiOps/add_rewards/arbitrum/USDC-Injector-rETH-wETH.json
MULTISIG: multisigs/lm (arbitrum:0xc38c5f97B34E175FFd35407fc91a937300E33860)
COMMIT: 49038dd35f08299cf0734f7f44e58465cc9f5843
CHAIN(S): arbitrum
TENDERLY: 🟩 SUCCESS

+---------------+-----------------------------------------------------------------------------------------------------------------+------------------------------------------------------------------------------+-----------------------------+-----------------------------------------------------------------------------------------------------+-----+----------+
| function      | entrypoint                                                                                                      | target                                                                       | selector                    | parsed_inputs                                                                                       | bip | tx_index |
+---------------+-----------------------------------------------------------------------------------------------------------------+------------------------------------------------------------------------------+-----------------------------+-----------------------------------------------------------------------------------------------------+-----+----------+
| performAction | 0x97207B095e4D5C9a6e4cfbfcd2C3358E03B90c4A (20221124-authorizer-adaptor-entrypoint/AuthorizerAdaptorEntrypoint) | 0x8ba2d53f34159c5c5e7add60b56c7de3bbc1da68 (gauges/rETH/wETH BPT-gauge-8ba2) | add_reward(address,address) | 0xaf88d065e77c8cC2239327C5EDb3A432268e5831: USDC                                                    | N/A |    0     |
|               |                                                                                                                 |                                                                              |                             | 0xabC414cEE2F6E8Ee262d6dc106c86A3f627f84D2: maxiKeepers/gaugeRewardsInjectors/usdc_rewards_injector |     |          |
+---------------+-----------------------------------------------------------------------------------------------------------------+------------------------------------------------------------------------------+-----------------------------+-----------------------------------------------------------------------------------------------------+-----+----------+

FILENAME: MaxiOps/add_rewards/base/USDC-Injector-rETH-wETH.json
MULTISIG: multisigs/lm (base:0x65226673F3D202E0f897C862590d7e1A992B2048)
COMMIT: 49038dd35f08299cf0734f7f44e58465cc9f5843
CHAIN(S): base
TENDERLY: 🟩 SUCCESS

+---------------+-----------------------------------------------------------------------------------------------------------------+------------------------------------------------------------------------------+-----------------------------+------------------------------------------------------------------------------------+-----+----------+
| function      | entrypoint                                                                                                      | target                                                                       | selector                    | parsed_inputs                                                                      | bip | tx_index |
+---------------+-----------------------------------------------------------------------------------------------------------------+------------------------------------------------------------------------------+-----------------------------+------------------------------------------------------------------------------------+-----+----------+
| performAction | 0x9129E834e15eA19b6069e8f08a8EcFc13686B8dC (20221124-authorizer-adaptor-entrypoint/AuthorizerAdaptorEntrypoint) | 0x8D118063B521e0CB9947A934BE90f7e32d02b158 (gauges/rETH-WETH-BPT-gauge-8d11) | add_reward(address,address) | 0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913: tokens/USDC                            | N/A |    0     |
|               |                                                                                                                 |                                                                              |                             | 0xA6E7840Fc8193cFeBDdf177fa410038E5DD08f7A: maxiKeepers/gaugeRewardsInjectors/usdc |     |          |
+---------------+-----------------------------------------------------------------------------------------------------------------+------------------------------------------------------------------------------+-----------------------------+------------------------------------------------------------------------------------+-----+----------+

FILENAME: MaxiOps/add_rewards/optimism/USDC-Injector-rETH-wETH.json
MULTISIG: multisigs/lm (optimism:0x09Df1626110803C7b3b07085Ef1E053494155089)
COMMIT: 49038dd35f08299cf0734f7f44e58465cc9f5843
CHAIN(S): optimism
TENDERLY: 🟩 SUCCESS

+---------------+-----------------------------------------------------------------------------------------------------------------+-----------------------------------------------------------------------------+-----------------------------+------------------------------------------------------------------------------------+-----+----------+
| function      | entrypoint                                                                                                      | target                                                                      | selector                    | parsed_inputs                                                                      | bip | tx_index |
+---------------+-----------------------------------------------------------------------------------------------------------------+-----------------------------------------------------------------------------+-----------------------------+------------------------------------------------------------------------------------+-----+----------+
| performAction | 0xed86ff0c507D3AF5F35d3523B77C17415FCfFaCb (20221124-authorizer-adaptor-entrypoint/AuthorizerAdaptorEntrypoint) | 0xF27D53f21d024643d50de50183932F17638229F6 (gauges/BPT-rETH-ETH-gauge-f27d) | add_reward(address,address) | 0x0b2C639c533813f4Aa9D7837CAf62653d097Ff85: USDC                                   | N/A |    0     |
|               |                                                                                                                 |                                                                             |                             | 0x79D0F97D4D8c1Dd30b1Ea09746dB8847036AD92d: maxiKeepers/gaugeRewardsInjectors/usdc |     |          |
+---------------+-----------------------------------------------------------------------------------------------------------------+-----------------------------------------------------------------------------+-----------------------------+------------------------------------------------------------------------------------+-----+----------+

@Zen-Maxi Zen-Maxi merged commit c5ae4d9 into main Oct 31, 2024
@Zen-Maxi Zen-Maxi deleted the USDC-Injector-Reward-adds-Rocketpool branch October 31, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosuto-inzasheru gosuto-inzasheru gosuto-inzasheru approved these changes

@Xeonus Xeonus Awaiting requested review from Xeonus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zen-Maxi @gosuto-inzasheru