Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BIP-730] Enable two E-CLP gauges [Ethereum] #1482

Merged
merged 4 commits into from
Nov 4, 2024
Merged

[BIP-730] Enable two E-CLP gauges [Ethereum] #1482

merged 4 commits into from
Nov 4, 2024

Conversation

Xeonus
Copy link
Collaborator

@Xeonus Xeonus commented Oct 30, 2024

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

FILENAME: BIPs/2024-W45/BIP-730.json
COMMIT: 12485dee9c551c119a8d15820811eaab1d91a8e0

Validator Result
validate_contains_msig ✅
validate_msig_in_address_book ✅
validate_chain_specified ✅
validate_file_has_bip ✅
validate_path_has_weekly_dir ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

FILENAME: BIPs/2024-W45/BIP-730.json
MULTISIG: multisigs/lm (mainnet:0xc38c5f97B34E175FFd35407fc91a937300E33860)
COMMIT: 12485dee9c551c119a8d15820811eaab1d91a8e0
CHAIN(S): mainnet
TENDERLY: 🟩 SUCCESS

Gauge Validator Result
validate_preferential_gauge ✅
validate_rate_providers_safety -- 
+-----------------------+---------------------------------------------------------------------+--------------------+--------------------------------------------------+----------------------------------------------------+--------------------------------------------+----------------+---------+----------+
| function              | pool_id_and_address                                                 | symbol_and_info    | gauge_address_and_info                           | tokens                                             | rate_providers                             | review_summary |   bip   | tx_index |
+-----------------------+---------------------------------------------------------------------+--------------------+--------------------------------------------------+----------------------------------------------------+--------------------------------------------+----------------+---------+----------+
| GaugeAdderV4/addGauge | 0xc683955059e98350de4e5dc1c75971bd640829bb0002000000000000000006e1  | ECLP-cbETH-wstETH  | root: 0x655A2B240151b4fAb06dfb2B6329eF72647F89dd | 0x7f39C581F595B53c5cb19bD0b3f8dA6c935E2Ca0: wstETH | 0x72D07D7DcA67b8A406aD1Ec34ce969c90bFEE768 |      safe      | BIP-730 |    0     |
|                       | pool_address: 0xC683955059e98350DE4e5Dc1C75971bD640829Bb            | fee: 0.03          | side: None                                       | 0xBe9895146f7AF43049ca1c1AE358B0541Ea49704: cbETH  | 0x7311E4BB8a72e7B300c5B8BDE4de6CdaA822a5b1 |      safe      |         |          |
|                       |                                                                     | a-factor: N/A      | style: mainnet                                   |                                                    |                                            |                |         |          |
|                       |                                                                     |                    | cap: 100.0%                                      |                                                    |                                            |                |         |          |
|                       |                                                                     |                    | preferential: True                               |                                                    |                                            |                |         |          |
| GaugeAdderV4/addGauge | 0x9d73398c54be236da189d937eace8e6dccad36160002000000000000000006e3  | ECLP-cbBTC-WBTC    | root: 0xF3E9A97e5fEddf961A3d431627561bbFc7cFb6cf | 0x2260FAC5E5542a773Aa44fBCfeDf7C193bc2C599: WBTC   | 0x0000000000000000000000000000000000000000 |       --       | BIP-730 |    1     |
|                       | pool_address: 0x9D73398C54be236da189d937EACE8E6dccaD3616            | fee: 0.02          | side: None                                       | 0xcbB7C0000aB88B473b1f5aFd9ef808440eed33Bf: cbBTC  | 0x0000000000000000000000000000000000000000 |       --       |         |          |
|                       |                                                                     | a-factor: N/A      | style: mainnet                                   |                                                    |                                            |                |         |          |
|                       |                                                                     |                    | cap: 100.0%                                      |                                                    |                                            |                |         |          |
|                       |                                                                     |                    | preferential: True                               |                                                    |                                            |                |         |          |
+-----------------------+---------------------------------------------------------------------+--------------------+--------------------------------------------------+----------------------------------------------------+--------------------------------------------+----------------+---------+----------+

@gosuto-inzasheru
Copy link
Collaborator

gosuto-inzasheru commented Oct 31, 2024 •
edited
Loading

@Xeonus filename does not contain the bip#. not sure if that is an absolute must for non dao msig txs?

best to adhere to the requirement of having it in the filename imo

gosuto-inzasheru
gosuto-inzasheru requested changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs bip# in filename

@Xeonus
Copy link
Collaborator Author

Xeonus commented Oct 31, 2024

@gosuto-inzasheru - this PR was prepared through the Ops UI and I simply forgot to label the BIP-ID, fixing

@gosuto-inzasheru gosuto-inzasheru merged commit 1d486b6 into BalancerMaxis:main Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosuto-inzasheru gosuto-inzasheru gosuto-inzasheru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xeonus @gosuto-inzasheru