Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BIP-732] Permissions Policy Update Request #6 (Gnosis Chain) #1450

Merged
merged 8 commits into from
Nov 19, 2024

Conversation

JeronimoHoulin
Copy link
Contributor

No description provided.

@JeronimoHoulin JeronimoHoulin changed the title payload with permissions for PUR6 (Gnosis Chain) Payload for PUR#6 (Gnosis Chain) Oct 21, 2024
Copy link
Contributor

github-actions bot commented Oct 21, 2024

FILENAME: BIPs/2024-W46/[BIP-732] Permissions Policy Update Request #6.json
COMMIT: 2de24fdfcc4183f3c5c2340da3664ef33ef25b60

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified
validate_file_has_bip
validate_path_has_weekly_dir

@gosuto-inzasheru
Copy link
Collaborator

Copy link
Collaborator

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did a review of the permissions change here: https://forum.balancer.fi/t/bip-xxx-permissions-policy-update-request-6-gnosis-chain/6130/2?u=gosuto

it would be good to get a response on seednode write functions point

@gosuto-inzasheru
Copy link
Collaborator

write funcs indeed now visible on gnosisscan

if you can move the payload into week46 then this is good to go!

@gosuto-inzasheru gosuto-inzasheru changed the title Payload for PUR#6 (Gnosis Chain) [BIP-732] Permissions Policy Update Request #6 (Gnosis Chain) Nov 6, 2024
Copy link
Collaborator

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • confirmed content using zodiac roles ui (see my post on the forum)
  • payload json matches the one downloadable from zodiac roles ui

@gosuto-inzasheru gosuto-inzasheru merged commit be2d9be into main Nov 19, 2024
@gosuto-inzasheru gosuto-inzasheru deleted the pur6 branch November 19, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants