[BIP-726] Adopt SEAL Whitehat Safe Harbor Agreement #1433

DicksonWu654 · 2024-10-15T19:42:12Z

Adopt SEAL Whitehat Safe Harbor Agreement on chain at 0x8f72fcf695523A6FC7DD97EafDd7A083c386b7b6. Calling adoptSafeHarbor with the these parameters balancerAdoptionParameters.json

github-actions · 2024-10-15T20:02:50Z

FILENAME: BIPs/2024-W44/[BIP-726] Adopt SEAL Whitehat Safe Harbor Agreement.json
COMMIT: 522fd1cde962ece50390e3fcd243c1759dab9f9f

Validator	Result
`validate_contains_msig`	✅
`validate_msig_in_address_book`	✅
`validate_chain_specified`	✅
`validate_file_has_bip`	✅
`validate_path_has_weekly_dir`	✅

github-actions · 2024-10-15T20:02:50Z

FILENAME: BIPs/2024-W44/[BIP-726] Adopt SEAL Whitehat Safe Harbor Agreement.json
MULTISIG: multisigs/lm (mainnet:0xc38c5f97B34E175FFd35407fc91a937300E33860)
COMMIT: 522fd1cde962ece50390e3fcd243c1759dab9f9f
CHAIN(S): mainnet
TENDERLY: 🟪 SKIPPED (Web3ValidationError("\nCould not identify the intended function with name adoptSafeHarbor, positional arguments with type(s) strand keyword arguments with type(s){}.\nFound 1 function(s) with the name adoptSafeHarbor: ['adoptSafeHarbor((string,(string,string)[],(address,(address,uint8,bytes)[],uint256)[],(uint256,uint256,bool,uint8,string),string))']\nFunction invocation failed due to no matching argument types."))

+-----------------+-------------------------------------------------------------------+-------+----------------------------------------------------------------------------------------------------------------------------------------------------------------+------------+----------+
| fx_name         | to                                                                | value | inputs                                                                                                                                                         | bip_number | tx_index |
+-----------------+-------------------------------------------------------------------+-------+----------------------------------------------------------------------------------------------------------------------------------------------------------------+------------+----------+
| adoptSafeHarbor | 0x8f72fcf695523A6FC7DD97EafDd7A083c386b7b6 (safe_harbor/registry) | 0     | {                                                                                                                                                              | BIP-726    |   N/A    |
|                 |                                                                   |       |   "details": [                                                                                                                                                 |            |          |
|                 |                                                                   |       |     "\"Balancer\"",                                                                                                                                            |            |          |
|                 |                                                                   |       |     "[[\"Telegram:Mikeisballin\"",                                                                                                                             |            |          |
|                 |                                                                   |       |     "\"MikeB-Strategy\"]]",                                                                                                                                    |            |          |
|                 |                                                                   |       |     "[[\"0x10A19e7eE7d7F8a52822f6817de8ea18204F2e4f\"",                                                                                                        |            |          |
|                 |                                                                   |       |     "[[\"0xBA12222222228d8Ba445958a75a0704d566BF2C8\"",                                                                                                        |            |          |
|                 |                                                                   |       |     "0",                                                                                                                                                       |            |          |
|                 |                                                                   |       |     "\"0x\"]]",                                                                                                                                                |            |          |
|                 |                                                                   |       |     "1]",                                                                                                                                                      |            |          |
|                 |                                                                   |       |     "[\"0xaF23DC5983230E9eEAf93280e312e57539D098D0\"",                                                                                                         |            |          |
|                 |                                                                   |       |     "[[\"0xBA12222222228d8Ba445958a75a0704d566BF2C8\"",                                                                                                        |            |          |
|                 |                                                                   |       |     "0",                                                                                                                                                       |            |          |
|                 |                                                                   |       |     "\"0x\"]]",                                                                                                                                                |            |          |
|                 |                                                                   |       |     "42161]",                                                                                                                                                  |            |          |
|                 |                                                                   |       |     "[\"0x17b11FF13e2d7bAb2648182dFD1f1cfa0E4C7cf3\"",                                                                                                         |            |          |
|                 |                                                                   |       |     "[[\"0xBA12222222228d8Ba445958a75a0704d566BF2C8\"",                                                                                                        |            |          |
|                 |                                                                   |       |     "0",                                                                                                                                                       |            |          |
|                 |                                                                   |       |     "\"0x\"]]",                                                                                                                                                |            |          |
|                 |                                                                   |       |     "43114]",                                                                                                                                                  |            |          |
|                 |                                                                   |       |     "[\"0xC40DCFB13651e64C8551007aa57F9260827B6462\"",                                                                                                         |            |          |
|                 |                                                                   |       |     "[[\"0xBA12222222228d8Ba445958a75a0704d566BF2C8\"",                                                                                                        |            |          |
|                 |                                                                   |       |     "0",                                                                                                                                                       |            |          |
|                 |                                                                   |       |     "\"0x\"]]",                                                                                                                                                |            |          |
|                 |                                                                   |       |     "8453]",                                                                                                                                                   |            |          |
|                 |                                                                   |       |     "[\"0x4f22C2784Cbd2B24a172566491Ee73fee1A63c2e\"",                                                                                                         |            |          |
|                 |                                                                   |       |     "[[\"0xBA12222222228d8Ba445958a75a0704d566BF2C8\"",                                                                                                        |            |          |
|                 |                                                                   |       |     "0",                                                                                                                                                       |            |          |
|                 |                                                                   |       |     "\"0x\"]]",                                                                                                                                                |            |          |
|                 |                                                                   |       |     "252]",                                                                                                                                                    |            |          |
|                 |                                                                   |       |     "[\"0x2a5AEcE0bb9EfFD7608213AE1745873385515c18\"",                                                                                                         |            |          |
|                 |                                                                   |       |     "[[\"0xBA12222222228d8Ba445958a75a0704d566BF2C8\"",                                                                                                        |            |          |
|                 |                                                                   |       |     "0",                                                                                                                                                       |            |          |
|                 |                                                                   |       |     "\"0x\"]]",                                                                                                                                                |            |          |
|                 |                                                                   |       |     "100]",                                                                                                                                                    |            |          |
|                 |                                                                   |       |     "[\"0x4f22C2784Cbd2B24a172566491Ee73fee1A63c2e\"",                                                                                                         |            |          |
|                 |                                                                   |       |     "[[\"0xBA12222222228d8Ba445958a75a0704d566BF2C8\"",                                                                                                        |            |          |
|                 |                                                                   |       |     "0",                                                                                                                                                       |            |          |
|                 |                                                                   |       |     "\"0x\"]]",                                                                                                                                                |            |          |
|                 |                                                                   |       |     "34443]",                                                                                                                                                  |            |          |
|                 |                                                                   |       |     "[\"0x043f9687842771b3dF8852c1E9801DCAeED3f6bc\"",                                                                                                         |            |          |
|                 |                                                                   |       |     "[[\"0xBA12222222228d8Ba445958a75a0704d566BF2C8\"",                                                                                                        |            |          |
|                 |                                                                   |       |     "0",                                                                                                                                                       |            |          |
|                 |                                                                   |       |     "\"0x\"]]",                                                                                                                                                |            |          |
|                 |                                                                   |       |     "10]",                                                                                                                                                     |            |          |
|                 |                                                                   |       |     "[\"0xeE071f4B516F69a1603dA393CdE8e76C40E5Be85\"",                                                                                                         |            |          |
|                 |                                                                   |       |     "[[\"0xBA12222222228d8Ba445958a75a0704d566BF2C8\"",                                                                                                        |            |          |
|                 |                                                                   |       |     "0",                                                                                                                                                       |            |          |
|                 |                                                                   |       |     "\"0x\"]]",                                                                                                                                                |            |          |
|                 |                                                                   |       |     "137]",                                                                                                                                                    |            |          |
|                 |                                                                   |       |     "[\"0x2f237e7643a3bF6Ef265dd6FCBcd26a7Cc38dbAa\"",                                                                                                         |            |          |
|                 |                                                                   |       |     "[[\"0xBA12222222228d8Ba445958a75a0704d566BF2C8\"",                                                                                                        |            |          |
|                 |                                                                   |       |     "0",                                                                                                                                                       |            |          |
|                 |                                                                   |       |     "\"0x\"]]",                                                                                                                                                |            |          |
|                 |                                                                   |       |     "1101]]",                                                                                                                                                  |            |          |
|                 |                                                                   |       |     "[10",                                                                                                                                                     |            |          |
|                 |                                                                   |       |     "1000000",                                                                                                                                                 |            |          |
|                 |                                                                   |       |     "false",                                                                                                                                                   |            |          |
|                 |                                                                   |       |     "2",                                                                                                                                                       |            |          |
|                 |                                                                   |       |     "\"KYC&GlobalSanctionVerification.BalancerrequiresalleligiblewhitehatstoundergoKnowYourCustomer(KYC)verificationandbescreenedagainstglobalsanctionslists", |            |          |
|                 |                                                                   |       |     "includingOFAC",                                                                                                                                           |            |          |
|                 |                                                                   |       |     "UK",                                                                                                                                                      |            |          |
|                 |                                                                   |       |     "andEUregulations.Thisprocessensuresthatallbountyrecipientsarecompliantwithlegalandregulatorystandardsbeforequalifyingforpayment.\"]",                     |            |          |
|                 |                                                                   |       |     "\"https://bafybeiakxvysdvsvupqcibkpifugzwcnllzt2udjk3l4yhcix7dqxxqyp4.ipfs.w3s.link/agreement.pdf\""                                                      |            |          |
|                 |                                                                   |       |   ]                                                                                                                                                            |            |          |
|                 |                                                                   |       | }                                                                                                                                                              |            |          |
+-----------------+-------------------------------------------------------------------+-------+----------------------------------------------------------------------------------------------------------------------------------------------------------------+------------+----------+

… reports) + reformat JSON

Tritium-VLK · 2024-10-15T20:04:53Z

@DicksonWu654 is there somewhere official to verify the contract at address 0x8f72fcf695523A6FC7DD97EafDd7A083c386b7b6? Perhaps some docs by Safe Harbor with deployment addresses?

DicksonWu654 · 2024-10-15T20:09:30Z

Thank you for reviewing!

Yep it's in the official github legal document here: https://github.com/security-alliance/safe-harbor/blob/main/documents/agreement.pdf

It's on page 9 or 1.1 c

Would you like it to be more explicit / more easily accessible?

DicksonWu654 · 2024-10-15T20:13:04Z

Not sure why the tenderly simulation failed. I simulated it after I inputted the fields in the Gnosis Safe UI and it seemed to work: https://dashboard.tenderly.co/public/safe/safe-apps/simulator/dba0a8d3-cba7-4057-a583-be2320bb569a

Tritium-VLK · 2024-10-15T20:38:51Z

Not sure why the tenderly simulation failed. I simulated it after I inputted the fields in the Gnosis Safe UI and it seemed to work: https://dashboard.tenderly.co/public/safe/safe-apps/simulator/dba0a8d3-cba7-4057-a583-be2320bb569a

The auto tenderly code doesn't always work on complex payloads. Also the address decoding isn't working with all the special characters in the calldata. We'll do a little work and see if we can improve things, but will of course check tenderly and addresses manually if we can't get our reporting to work.

Tritium-VLK · 2024-10-15T20:41:53Z

Thank you for reviewing!

Yep it's in the official github legal document here: https://github.com/security-alliance/safe-harbor/blob/main/documents/agreement.pdf

It's on page 9 or 1.1 c

Would you like it to be more explicit / more easily accessible?

We add all known addresses to our address book. The PR to add involves a verification process. At best there is somewhere I can link, and copypasta the same address from on an official safe harbor site. I wasn't able to copy-paste the address easily in this PDF. If it's not a hassle a slightly easier to handle reference would be nice :)

DicksonWu654 · 2024-10-15T20:50:04Z

Not sure why the tenderly simulation failed. I simulated it after I inputted the fields in the Gnosis Safe UI and it seemed to work: https://dashboard.tenderly.co/public/safe/safe-apps/simulator/dba0a8d3-cba7-4057-a583-be2320bb569a

The auto tenderly code doesn't always work on complex payloads. Also the address decoding isn't working with all the special characters in the calldata. We'll do a little work and see if we can improve things, but will of course check tenderly and addresses manually if we can't get our reporting to work.

Ah let me try to do the payload without the \n :)

DicksonWu654 · 2024-10-15T20:50:28Z

Thank you for reviewing!
Yep it's in the official github legal document here: https://github.com/security-alliance/safe-harbor/blob/main/documents/agreement.pdf
It's on page 9 or 1.1 c
Would you like it to be more explicit / more easily accessible?

We add all known addresses to our address book. The PR to add involves a verification process. At best there is somewhere I can link, and copypasta the same address from on an official safe harbor site. I wasn't able to copy-paste the address easily in this PDF. If it's not a hassle a slightly easier to handle reference would be nice :)

Got it I got it!

… reports) + reformat JSON

DicksonWu654 · 2024-10-15T22:39:50Z

Alright just pushed something to remove all the extra spaces & remove the / from the "N/A". Not sure if that'll fix it though 😓

DicksonWu654 · 2024-10-15T22:40:38Z

Thank you for reviewing!
Yep it's in the official github legal document here: https://github.com/security-alliance/safe-harbor/blob/main/documents/agreement.pdf
It's on page 9 or 1.1 c
Would you like it to be more explicit / more easily accessible?

We add all known addresses to our address book. The PR to add involves a verification process. At best there is somewhere I can link, and copypasta the same address from on an official safe harbor site. I wasn't able to copy-paste the address easily in this PDF. If it's not a hassle a slightly easier to handle reference would be nice :)

Alrighty does this work? https://github.com/security-alliance/safe-harbor/blob/main/documents/deployment.txt

… reports) + reformat JSON

0xDanko · 2024-10-17T15:57:13Z

Hey fellas, our in-house counselor had some bits to add on the agreement - I left a comment of the forum proposal. Also, please add that you will abide to the DAO standards and accountability guidelines.
Balancer SAFE Harbor agreement (Balancer Edits) (1).pdf

DicksonWu654 · 2024-10-17T17:52:54Z

Hey fellas, our in-house counselor had some bits to add on the agreement - I left a comment of the forum proposal. Also, please add that you will abide to the DAO standards and accountability guidelines. Balancer SAFE Harbor agreement (Balancer Edits) (1).pdf

Hi! I replied on the forum!

DicksonWu654 · 2024-10-18T04:34:53Z

Just updated the payload to reflect the new state. The changes are:

Identity Verification from Anonymous to Named
Diligence Requirement from "N/A" to "KYC & Global Sanction Verification. Balancer requires all eligible whitehats to undergo Know Your Customer (KYC) verification and be screened against global sanctions lists, including OFAC, UK, and EU regulations. This process ensures that all bounty recipients are compliant with legal and regulatory standards before qualifying for payment."

Simulated on tenderly here: https://dashboard.tenderly.co/public/safe/safe-apps/simulator/d21db244-0ead-4a1b-8803-fe5b5e768cc8/logs

Here are the parameters too balancerAdoption.json

… reports) + reformat JSON

gosuto-inzasheru

current payload translates to:

10% bounty
in $bal
on chains ethereum, arbitrum, avalanche, base, fraxtal, gnosis, mode, optimism, polygon and zkevm
requires kyc
balancer vault as the account in question

balancer vault and dao msig addresses check out for all chains

gosuto-inzasheru · 2024-10-21T13:53:34Z

@DicksonWu654 can you please move the payload to week 44?

DicksonWu654 · 2024-10-21T16:17:35Z

Yes will do!

… reports) + reformat JSON

0xDanko · 2024-10-22T16:59:18Z

@gosuto-inzasheru
From our end, this looks good with the proposed changes.

gosuto-inzasheru · 2024-10-23T10:23:55Z

@DicksonWu654 i just numbered this bip. if you can reflect that change in this pr we can approve it and include it in this week's gov round! sorry for all the admin, appreciate the efforts!

prop: https://forum.balancer.fi/t/bip-726-adopt-the-seal-safe-harbor-agreement/6087

DicksonWu654 · 2024-10-23T16:16:34Z

@DicksonWu654 i just numbered this bip. if you can reflect that change in this pr we can approve it and include it in this week's gov round! sorry for all the admin, appreciate the efforts!

prop: https://forum.balancer.fi/t/bip-726-adopt-the-seal-safe-harbor-agreement/6087

Thank you so much @gosuto-inzasheru! I just changed the BIP numbers!

… reports) + reformat JSON

gosuto-inzasheru · 2024-10-29T03:07:15Z

@DicksonWu654 you payload executes this from our lm (liquidity mining) multisig, not the dao multisig. is this correct? (does it matter?)

DicksonWu654 · 2024-10-29T03:16:09Z

@DicksonWu654 you payload executes this from our lm (liquidity mining) multisig, not the dao multisig. is this correct? (does it matter?)

Oh no I didn't mean to do that 😓. Is it possible to change it, or would we need to re-do a DAO vote. But I think it's fine if it's from the lm multisig - as long as the DAO approved of it

BIP: Adding Adopt Safe Harbor multisig payload json

4003b30

DicksonWu654 temporarily deployed to external October 15, 2024 19:42 — with GitHub Actions Inactive

Automated processing of Payload PR (validations, transformations, and…

05081fa

… reports) + reformat JSON

Merge branch 'main' into main

5bbbd9f

DicksonWu654 temporarily deployed to external October 15, 2024 20:21 — with GitHub Actions Inactive

DicksonWu654 and others added 2 commits October 15, 2024 21:17

Automated processing of Payload PR (validations, transformations, and…

2f44e5a

… reports) + reformat JSON

Adjusting Safe Harbor Adoption json

7c4cab7

DicksonWu654 temporarily deployed to external October 15, 2024 22:33 — with GitHub Actions Inactive

Tritium-VLK mentioned this pull request Oct 16, 2024

add safe_harbor registry BalancerMaxis/bal_addresses#485

Merged

Automated processing of Payload PR (validations, transformations, and…

5c10a62

… reports) + reformat JSON

Zen-Maxi changed the title ~~[BIP-XXX] Adopt SEAL Whitehat Safe Harbor Agreement~~ [BIP-719] Adopt SEAL Whitehat Safe Harbor Agreement Oct 17, 2024

Zen-Maxi changed the title ~~[BIP-719] Adopt SEAL Whitehat Safe Harbor Agreement~~ [BIP-XXX] Adopt SEAL Whitehat Safe Harbor Agreement Oct 17, 2024

Updating details Identity Verification & Diligence Requirements

4603e85

DicksonWu654 temporarily deployed to external October 18, 2024 04:33 — with GitHub Actions Inactive

Automated processing of Payload PR (validations, transformations, and…

8488433

… reports) + reformat JSON

gosuto-inzasheru requested a review from 0xDanko October 21, 2024 08:45

gosuto-inzasheru reviewed Oct 21, 2024

View reviewed changes

Moving BIPs to W44

a91e988

DicksonWu654 temporarily deployed to external October 21, 2024 16:19 — with GitHub Actions Inactive

Automated processing of Payload PR (validations, transformations, and…

8922362

… reports) + reformat JSON

gosuto-inzasheru changed the title ~~[BIP-XXX] Adopt SEAL Whitehat Safe Harbor Agreement~~ [BIP-726] Adopt SEAL Whitehat Safe Harbor Agreement Oct 23, 2024

Setting BIP number

522fd1c

DicksonWu654 temporarily deployed to external October 23, 2024 16:15 — with GitHub Actions Inactive

Automated processing of Payload PR (validations, transformations, and…

008b506

… reports) + reformat JSON

gosuto-inzasheru approved these changes Oct 23, 2024

View reviewed changes

gosuto-inzasheru merged commit 1f5f3cc into BalancerMaxis:main Oct 28, 2024

gosuto-inzasheru mentioned this pull request Oct 29, 2024

fix: register safe harbor from dao msig #1473

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BIP-726] Adopt SEAL Whitehat Safe Harbor Agreement #1433

[BIP-726] Adopt SEAL Whitehat Safe Harbor Agreement #1433

DicksonWu654 commented Oct 15, 2024

github-actions bot commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading

Tritium-VLK commented Oct 15, 2024

DicksonWu654 commented Oct 15, 2024

DicksonWu654 commented Oct 15, 2024

Tritium-VLK commented Oct 15, 2024

Tritium-VLK commented Oct 15, 2024

DicksonWu654 commented Oct 15, 2024

DicksonWu654 commented Oct 15, 2024

DicksonWu654 commented Oct 15, 2024

DicksonWu654 commented Oct 15, 2024

0xDanko commented Oct 17, 2024

DicksonWu654 commented Oct 17, 2024

DicksonWu654 commented Oct 18, 2024

gosuto-inzasheru left a comment •

edited

Loading

gosuto-inzasheru commented Oct 21, 2024

DicksonWu654 commented Oct 21, 2024

0xDanko commented Oct 22, 2024

gosuto-inzasheru commented Oct 23, 2024

DicksonWu654 commented Oct 23, 2024

gosuto-inzasheru commented Oct 29, 2024

DicksonWu654 commented Oct 29, 2024

[BIP-726] Adopt SEAL Whitehat Safe Harbor Agreement #1433

[BIP-726] Adopt SEAL Whitehat Safe Harbor Agreement #1433

Conversation

DicksonWu654 commented Oct 15, 2024

github-actions bot commented Oct 15, 2024 • edited Loading

github-actions bot commented Oct 15, 2024 • edited Loading

Tritium-VLK commented Oct 15, 2024

DicksonWu654 commented Oct 15, 2024

DicksonWu654 commented Oct 15, 2024

Tritium-VLK commented Oct 15, 2024

Tritium-VLK commented Oct 15, 2024

DicksonWu654 commented Oct 15, 2024

DicksonWu654 commented Oct 15, 2024

DicksonWu654 commented Oct 15, 2024

DicksonWu654 commented Oct 15, 2024

0xDanko commented Oct 17, 2024

DicksonWu654 commented Oct 17, 2024

DicksonWu654 commented Oct 18, 2024

gosuto-inzasheru left a comment • edited Loading

Choose a reason for hiding this comment

gosuto-inzasheru commented Oct 21, 2024

DicksonWu654 commented Oct 21, 2024

0xDanko commented Oct 22, 2024

gosuto-inzasheru commented Oct 23, 2024

DicksonWu654 commented Oct 23, 2024

gosuto-inzasheru commented Oct 29, 2024

DicksonWu654 commented Oct 29, 2024

github-actions bot commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading

gosuto-inzasheru left a comment •

edited

Loading