Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate mainnet upkeeps to omni msig #1059

Merged
merged 7 commits into from
Jul 2, 2024
Merged

Conversation

gosuto-inzasheru
Copy link
Collaborator

closes #1057

  • part1 (lm msig):
    • set new keeper on vebal injector
    • transfer ownership of vebal injector and ozpoker to omni msig
  • part2 (maxi ops msig):
    • set new keeper on gas station
    • transfer ownership of gas station to omni msig
  • part3 (omni msig):
    • accept ownership of vebal injector, ozpoker and gas station

@gosuto-inzasheru gosuto-inzasheru changed the title Issue/1057 chore: migrate mainnet upkeeps to omni msig Jun 14, 2024
Tritium-VLK
Tritium-VLK previously approved these changes Jun 14, 2024
Copy link
Contributor

@Tritium-VLK Tritium-VLK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good/can load. Would really be good to find a little more structure here for the files.

Maybe like chain/type/files

So polygon/gas/tx_onwershipandso.json?

Paylaods look fine though, want me to load them tomorrow/when I get a chance?

@gosuto-inzasheru
Copy link
Collaborator Author

Would really be good to find a little more structure here for the files.

actually i already regret moving these files into a subdir because now the whole reporting for this pr is messed up. i will move them back, and then i suggest you open a separate pr for whatever structure you have in mind

Paylaods look fine though, want me to load them tomorrow/when I get a chance?

yes, that is much welcomed!

@BalancerMaxis BalancerMaxis deleted a comment from github-actions bot Jun 16, 2024
@BalancerMaxis BalancerMaxis deleted a comment from github-actions bot Jun 16, 2024
@BalancerMaxis BalancerMaxis deleted a comment from github-actions bot Jun 16, 2024
@BalancerMaxis BalancerMaxis deleted a comment from github-actions bot Jun 16, 2024
Copy link
Contributor

BIP validation results for file MaxiOps/chainlinkAutomation/migrate_mainnet_part1.json:
Commit: 46ad953f6fd4ba61c65fed43a5b8d57d730e26ae

Validator Result
validate_contains_msig OK
validate_msig_in_address_book OK
validate_chain_specified OK
validate_file_has_bip No BIP number found in file path MaxiOps/chainlinkAutomation/migrate_mainnet_part1.json
validate_path_has_weekly_dir File MaxiOps/chainlinkAutomation/migrate_mainnet_part1.json has has no YYYY-W## in path

BIP validation results for file MaxiOps/chainlinkAutomation/migrate_mainnet_part2.json:
Commit: 46ad953f6fd4ba61c65fed43a5b8d57d730e26ae

Validator Result
validate_contains_msig OK
validate_msig_in_address_book OK
validate_chain_specified OK
validate_file_has_bip No BIP number found in file path MaxiOps/chainlinkAutomation/migrate_mainnet_part2.json
validate_path_has_weekly_dir File MaxiOps/chainlinkAutomation/migrate_mainnet_part2.json has has no YYYY-W## in path

BIP validation results for file MaxiOps/chainlinkAutomation/migrate_mainnet_part3.json:
Commit: 46ad953f6fd4ba61c65fed43a5b8d57d730e26ae

Validator Result
validate_contains_msig OK
validate_msig_in_address_book OK
validate_chain_specified OK
validate_file_has_bip No BIP number found in file path MaxiOps/chainlinkAutomation/migrate_mainnet_part3.json
validate_path_has_weekly_dir File MaxiOps/chainlinkAutomation/migrate_mainnet_part3.json has has no YYYY-W## in path

Copy link
Contributor

FILENAME: MaxiOps/chainlinkAutomation/migrate_mainnet_part1.json
MULTISIG: multisigs/lm (mainnet:0xc38c5f97B34E175FFd35407fc91a937300E33860)
COMMIT: 46ad953f6fd4ba61c65fed43a5b8d57d730e26ae
CHAIN(S): mainnet
TENDERLY: SUCCESS

+-------------------+------------------------------------------------------------------------------+-------+---------------------------------------------------------------------------------------+------------+----------+
| fx_name           | to                                                                           | value | inputs                                                                                | bip_number | tx_index |
+-------------------+------------------------------------------------------------------------------+-------+---------------------------------------------------------------------------------------+------------+----------+
| transferOwnership | 0xdDd5FF0E581f097573B13f247F6BE736f602F839 (maxiKeepers/LZRateProviderPoker) | 0     | {                                                                                     | N/A        |   N/A    |
|                   |                                                                              |       |   "to": [                                                                             |            |          |
|                   |                                                                              |       |     "0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e (multisigs/vote_incentive_recycling)" |            |          |
|                   |                                                                              |       |   ]                                                                                   |            |          |
|                   |                                                                              |       | }                                                                                     |            |          |
| setKeeperRegistry | 0x8AD2512819A7eae1dd398973EFfaE48dafBe8255 (maxiKeepers/veBalFeeInjector)    | 0     | {                                                                                     | N/A        |   N/A    |
|                   |                                                                              |       |   "_keeperRegistry": [                                                                |            |          |
|                   |                                                                              |       |     "0x4249093e75b2eECA9f3ba3171eA1f3fA186ABE9D (N/A)"                                |            |          |
|                   |                                                                              |       |   ]                                                                                   |            |          |
|                   |                                                                              |       | }                                                                                     |            |          |
| transferOwnership | 0x8AD2512819A7eae1dd398973EFfaE48dafBe8255 (maxiKeepers/veBalFeeInjector)    | 0     | {                                                                                     | N/A        |   N/A    |
|                   |                                                                              |       |   "to": [                                                                             |            |          |
|                   |                                                                              |       |     "0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e (multisigs/vote_incentive_recycling)" |            |          |
|                   |                                                                              |       |   ]                                                                                   |            |          |
|                   |                                                                              |       | }                                                                                     |            |          |
+-------------------+------------------------------------------------------------------------------+-------+---------------------------------------------------------------------------------------+------------+----------+

FILENAME: MaxiOps/chainlinkAutomation/migrate_mainnet_part2.json
MULTISIG: multisigs/maxi_ops (mainnet:0x166f54F44F271407f24AA1BE415a730035637325)
COMMIT: 46ad953f6fd4ba61c65fed43a5b8d57d730e26ae
CHAIN(S): mainnet
TENDERLY: SUCCESS

+-------------------+---------------------------------------------------------------------+-------+---------------------------------------------------------------------------------------+------------+----------+
| fx_name           | to                                                                  | value | inputs                                                                                | bip_number | tx_index |
+-------------------+---------------------------------------------------------------------+-------+---------------------------------------------------------------------------------------+------------+----------+
| setKeeperAddress  | 0x7fb8f5D04b521B6880158819E69538655AABD5c4 (maxiKeepers/gasStation) | 0     | {                                                                                     | N/A        |   N/A    |
|                   |                                                                     |       |   "keeperAddress": [                                                                  |            |          |
|                   |                                                                     |       |     "0x9795368b9DA5caaE45f214fF1d2Fdf0c9bbC56aa (N/A)"                                |            |          |
|                   |                                                                     |       |   ]                                                                                   |            |          |
|                   |                                                                     |       | }                                                                                     |            |          |
| transferOwnership | 0x7fb8f5D04b521B6880158819E69538655AABD5c4 (maxiKeepers/gasStation) | 0     | {                                                                                     | N/A        |   N/A    |
|                   |                                                                     |       |   "to": [                                                                             |            |          |
|                   |                                                                     |       |     "0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e (multisigs/vote_incentive_recycling)" |            |          |
|                   |                                                                     |       |   ]                                                                                   |            |          |
|                   |                                                                     |       | }                                                                                     |            |          |
+-------------------+---------------------------------------------------------------------+-------+---------------------------------------------------------------------------------------+------------+----------+

FILENAME: MaxiOps/chainlinkAutomation/migrate_mainnet_part3.json
MULTISIG: multisigs/vote_incentive_recycling (mainnet:0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e)
COMMIT: 46ad953f6fd4ba61c65fed43a5b8d57d730e26ae
CHAIN(S): mainnet
TENDERLY: FAILURE

+-----------------+------------------------------------------------------------------------------+-------+--------+------------+----------+
| fx_name         | to                                                                           | value | inputs | bip_number | tx_index |
+-----------------+------------------------------------------------------------------------------+-------+--------+------------+----------+
| acceptOwnership | 0xdDd5FF0E581f097573B13f247F6BE736f602F839 (maxiKeepers/LZRateProviderPoker) | 0     | "N/A"  | N/A        |   N/A    |
| acceptOwnership | 0x8AD2512819A7eae1dd398973EFfaE48dafBe8255 (maxiKeepers/veBalFeeInjector)    | 0     | "N/A"  | N/A        |   N/A    |
| acceptOwnership | 0x7fb8f5D04b521B6880158819E69538655AABD5c4 (maxiKeepers/gasStation)          | 0     | "N/A"  | N/A        |   N/A    |
+-----------------+------------------------------------------------------------------------------+-------+--------+------------+----------+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: migrate injector and gas station to omni msig on ethereum
2 participants