Merge pull request #1559 from BalancerMaxis/change-review-order

2024-W51 vlAURA votes + review vote hotfix
BalancerMaxis · Dec 6, 2024 · 4742388 · 4742388
2 parents 6491bcd + 0598edf
commit 4742388
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 15 deletions.
diff --git a/MaxiOps/vlaura_voting/2024/W51/input/BD Vote Template - December 5 2024.csv b/MaxiOps/vlaura_voting/2024/W51/input/BD Vote Template - December 5 2024.csv
@@ -39,4 +39,4 @@ APY needed,6%,,,
 Incentives per 1m,60000,,,
 Incentives per wk,"$1,154",,,
 Incentives per 6 wks,"$4,615",,,
-Total TVL to support,22,,,
+Total TVL to support,22,,,
diff --git a/tools/python/aura_snapshot_voting/review_votes.py b/tools/python/aura_snapshot_voting/review_votes.py
@@ -47,6 +47,20 @@ def review_votes(week_string):
     csv_file = csv_files[0]
     vote_df = pd.read_csv(csv_file)
 
+    try:
+        test_df = vote_df.copy()
+        prop, _, _ = _get_prop_and_determine_date_range()
+        test_df, vote_choices = prepare_vote_data(test_df, prop)
+        data = create_vote_payload(vote_choices, prop)
+        hash = hash_eip712_message(data)
+        vote_prep = f"\n### Vote Preparation\nSuccessfully simulated vote preparation ✅\nMessage hash: `0x{hash.hex()}`"
+        vote_check = True
+    except Exception as e:
+        vote_prep = (
+            f"\n### Vote Preparation\n❌ Error simulating vote preparation: {str(e)}"
+        )
+        vote_check = False
+
     vote_df = vote_df.dropna(subset=["Gauge Address", "Label", "Allocation %"])
 
     gauge_labels = fetch_gauge_labels()
@@ -61,19 +75,6 @@ def review_votes(week_string):
     total_allocation = vote_df["Allocation %"].str.rstrip("%").astype(float).sum()
     allocation_check = abs(total_allocation - 100) < 0.0001
 
-    try:
-        prop, _, _ = _get_prop_and_determine_date_range()
-        vote_df, vote_choices = prepare_vote_data(vote_df, prop)
-        data = create_vote_payload(vote_choices, prop)
-        hash = hash_eip712_message(data)
-        vote_prep = f"\n### Vote Preparation\nSuccessfully simulated vote preparation ✅\nMessage hash: `0x{hash.hex()}`"
-        vote_check = True
-    except Exception as e:
-        vote_prep = (
-            f"\n### Vote Preparation\n❌ Error simulating vote preparation: {str(e)}"
-        )
-        vote_check = False
-
     report = f"""## vLAURA Votes Review
 
 CSV file: `{os.path.relpath(csv_file, project_root)}`

diff --git a/tools/python/aura_snapshot_voting/vote.py b/tools/python/aura_snapshot_voting/vote.py
@@ -123,7 +123,7 @@ def prepare_vote_data(vote_df, prop):
     gauge_labels = {to_checksum_address(x["address"]): x["label"] for x in gauge_labels}
     choice_index_map = {c: x + 1 for x, c in enumerate(choices)}
 
-    vote_df = vote_df.dropna(subset=["Gauge Address"])
+    vote_df = vote_df.dropna(subset=["Gauge Address", "Label", "Allocation %"])
 
     vote_df["snapshot_label"] = vote_df["Gauge Address"].apply(
         lambda x: gauge_labels.get(to_checksum_address(x.strip()))