-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.9.3 move queries et al to bal_tools package. #269
Conversation
…graph to new package. bal_tools
…graph to new package. bal_tools
Also permissions seems to be having problems with rpc overload, not exactly related but looking into that. |
a09987b
to
601d050
Compare
Co-authored-by: gosuto.eth <[email protected]>
core pools run: https://github.com/BalancerMaxis/bal_addresses/actions/runs/8839258937 |
Note main perms still working: https://github.com/BalancerMaxis/bal_addresses/actions/runs/8839262089 |
Run without Fantom: https://github.com/BalancerMaxis/bal_addresses/actions/runs/8839777801 |
the problem seems to be infura rate limiting us (im guessing the github ip address) it appears to be for mainnet only, so maybe use alchemy for mainnet instead? then for fantom, if indeed there is no authoriser there then what is all this? https://github.com/BalancerMaxis/bal_addresses/blob/main/outputs/permissions/active/fantom.json note that either way that then finally not sure why you are commenting out base (commit message says " |
Why does it break on the main branch? The issue is that we don't actually have Balancer setup on Fantom, just 1 multisig there. When we added it, we pulled in a bunch of old stuff, and having fantom in the list for the authorizor runs was either pulling garbage data or crashing. We really don't want all those contracts from Fantom that are now in our docs/addressbook there as far as I know. They're not really still supported by the DAO. We can talk about that in the meeting today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- imports
BalPoolsGauges
andSubgraph
from new bal tools repo - remove all fantom permissions, but keep json
- move ethereum rpc calls to alchemy instead of infura
ok now it times out on optimism in infura: https://github.com/BalancerMaxis/bal_addresses/actions/runs/8893260208/job/24419053635 going to move all of them to alchemy |
@gosuto-inzasheru this good to merge? Need to update version first, and then release 0.9.3 after merge. |
yes sir, approving a review means i consider it ready to merge 👍 |
Hmm. You're the last commit and I made the PR so need someone else to review before we can merge... Heh. Will ping @Xeonus |
No description provided.