-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gauges to address book #159
Conversation
@Tritium-VLK i need some feedback here this pr would inject all preferential gauge addresses for all chains into the address book every weekend (via the cron jobbed this should help the ci reports label these gauges whenever they occur in a tx, it introduces great searchability for anyone (cmd-f the json), and is a first step in solving BalancerMaxis/multisig-ops#639 (custom reports for injector config payloads) however, i now realise that there arent any bpt addresses in the address book either! im thinking of doing the same for those. wdyt? |
hmm we would need to filter the pools query a bit, getting 7k pools currently across all chains!
|
note: pools should be written first, so they can be overwritten by deployments |
ok this is good to go; adds pools and gauges to the (reverse) address books |
to run locally, follow the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok let's try it and keep an eye on things and we can revert the dataset if there are problems. Will merge now, regen everything and then test a bunch of our tooling.
outputs/arbitrum.json
Outdated
"pools/25BAL-25MAGIC-25WETH-25USDC-4a5a": "0x4A5aE7cffcC25d3D7Be210b79DFf2Bc108864338", | ||
"pools/25BAL-25VST-25USDT-25USDC-6154": "0x61544DF209469AE004750D1D8d932F308E4647De", | ||
"pools/25BAL-25WBTC-25PHONON-25WETH-c188": "0xC1889C72D99917FD7b957fEd80d4Ea1eBd9e2618", | ||
"pools/25DPX-25VSTA-25DAI-25LINK-bd56": "0xBd566aaE6c2D7B778B4DC2009719932282b8df6F", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It somehow looks here like reverse records are being feed into the non-reverse flatbooks.
@@ -0,0 +1,7671 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is derived data (not a human input), i'd move these files to outputs.
So you could have like arbitrum_poolinfo.json and include the pools and gauges there/etc. Maybe it makes sense to just roll it all into one file. Let's think about it a bit more. I like the idea that the base flatbook is pretty clean, and the addresses by pool/gauge tend to have a lot of overlap/are more messy.
wip