Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revoke roles on Keeper and Registry ACL #1320

Merged
merged 4 commits into from
Jul 5, 2023
Merged

Revoke roles on Keeper and Registry ACL #1320

merged 4 commits into from
Jul 5, 2023

Conversation

sajanrajdev
Copy link
Collaborator

@sajanrajdev sajanrajdev commented Jun 28, 2023

Tackles #1316

For keeper run with:

brownie run scripts/issue/1316/remove_acl_permissions.py remove_keeper_acl_roles

For registry run with:

brownie run scripts/issue/1316/remove_acl_permissions.py remove_registry_acl_roles

Keeper removal to be ran on Mainnet. Registry removal to be ran on all chains.

@gosuto-inzasheru
Copy link
Collaborator

note: i merged main to prevent calling old gnosis safe api urls

Copy link
Collaborator

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirming final state for keeper on mainnet is:

Roles State:

+----------------+-----------------+--------------------------------------------+
| role           |   member_number | member_address                             |
+================+=================+============================================+
| HARVESTER_ROLE |               0 | 0xF8dbb94608E72A3C4cEeAB4ad495ac51210a341e |
+----------------+-----------------+--------------------------------------------+

final state for registry on mainnet is empty

i tried the registry nuke on arb1 and polygon as well. looks good there too, however tenderly sim url on arb1 fails for some reason (polygon is fine). maybe skip the tenderly url gen?

Copy link
Collaborator

@petrovska-petro petrovska-petro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that leaves only harvester role for bot in keeper acl and empties roles on registry acl ✅

@sajanrajdev sajanrajdev merged commit 3cf5dfe into main Jul 5, 2023
@sajanrajdev sajanrajdev deleted the issue1316 branch July 5, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants