Url cxn experiment #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checkpointing so it's not just here on my laptop.
…tCredentials instead of having to call the server to authorize the account.
| @@ -18,11 +19,10 @@ | |||
|
|
|||
|
|
|||
| @Test | |||
| public void testDefaultFactory_failsBecauseTestEnvironmentDoesntIncludeHttpClientJars() { | |||
| public void testDefaultFactory_failsSucceedsTestEnvironmentIncludesUrlBasedImplementation() { | |||
There was a problem hiding this comment.
would you please change "failsSucceeds" to just "succeeds", please? (i'm pretty sure that's my mistake!)
| private static File makeHugeFile(String fileNamePrefix) throws IOException { | ||
| final long fileSize = (long)Integer.MAX_VALUE + 1000*1000; | ||
| final long fileSize = 1000 * 1000 ;//(long)Integer.MAX_VALUE + 1000*1000; |
There was a problem hiding this comment.
is this a change i made? do you know why?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains both AB's B2WebApiUrlConnectionClientImpl and my B2AccountAuthorizerV5AuthImpl . It does not have the necessary changes to support Android pre API 26, which are significant, and required the elimination of some Java 8 language idioms and replacing the Java Date library with ThreeTenABP.