Skip to content

Commit

Permalink
Merge pull request #1056 from reef-technologies/fix-windows-sign
Browse files Browse the repository at this point in the history
Use SHA384withRSA for Windows signing
ppolewicz authored Nov 19, 2024
2 parents b489943 + 60d1a70 commit c71c029
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions changelog.d/+use_sha384_for_win_sign.infrastructure.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Use SHA384 for Windows signing instead of expired SHA256withRSA.
4 changes: 2 additions & 2 deletions noxfile.py
Original file line number Diff line number Diff line change
@@ -363,9 +363,9 @@ def sign_windows(cert_file, cert_password):
'/tr',
WINDOWS_TIMESTAMP_SERVER,
'/td',
'sha256',
'sha384',
'/fd',
'sha256',
'sha384',
f'dist/{binary_name}.exe',
external=True,
)

0 comments on commit c71c029

Please sign in to comment.