Depend on cmake only if there is no system package #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than requiring using `cmake` from PyPI unconditionally, check if `cmake` is available on the system, and add the dependency only if it is not. This is the same approach as used e.g. by `scikit-build-core` build system. Besides avoiding unnecessarily installing (or building) a second copy of CMake, it improves portability, as system CMake is often patched downstream whereas the CMake version found on PyPI is not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than requiring using
cmakefrom PyPI unconditionally, check ifcmakeis available on the system, and add the dependency only if it is not. This is the same approach as used e.g. byscikit-build-corebuild system. Besides avoiding unnecessarily installing (or building) a second copy of CMake, it improves portability, as system CMake is often patched downstream whereas the CMake version found on PyPI is not.