Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to english #13

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Change to english #13

wants to merge 11 commits into from

Conversation

rhuber6
Copy link
Contributor

@rhuber6 rhuber6 commented Mar 14, 2023

No description provided.

@rhuber6 rhuber6 requested a review from rileyhales March 14, 2023 19:29
# list_of_languages = [item for item in langs]
list_of_languages = ["check"]

target_directory = os.path.join(app_workspace.path, "Exact")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the list creation needs a fall back if this directory does not exist. consider if directory path exists, else structure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed... i think

tethysapp/hydro_var_monitor/controllers.py Outdated Show resolved Hide resolved
<!-- Modal content-->
<div class="modal-content">
<div class="modal-header">
<h5 class="modal-title" id="exampleModalLabel">Poner Latitud y Longitud </h5>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be in english or needs to be in a file which is different for each language

return {'success': False, 'error': f'Error Processing Request: {e}'}


@controller(name='admin-upload-simplified-zipped-data', url='hydro-var-monitor/admin/unzip-simplified',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should require the user to be logged in and be admin. See tethys docs for how to use the @login_required decorator and another decorator for being and admin user which i don't remember the name of.

@@ -215,21 +292,70 @@ def get_plot(request):
return JsonResponse(json.loads(json.dumps(plot_data)))


@controller(name='get_predefined', url='hydro-var-monitor/get-predefined',app_workspace=True)
@controller(name='admin-upload-exact-zipped-data', url='hydro-var-monitor/admin/unzip-exact', app_workspace=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should require the user to be logged in and be admin. See tethys docs for how to use the @login_required decorator and another decorator for being and admin user which i don't remember the name of.

}
return render(request, 'hydro_var_monitor/home.html', context)


@controller(name='admin', url='hydro-var-monitor/admin', app_workspace=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should require the user to be logged in and be admin. See tethys docs for how to use the @login_required decorator and another decorator for being and admin user which i don't remember the name of.

</br><br>
<div class="form-group">
<p>This second zipfile should contain json files with the approximate boundaries. The json files must be the
exact same names as there corresponding json file. If there are
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a link to download an example zipped dataset with a single json in the exact and simplified directories for reference.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put it in the public directory, perhaps in a subfolder called samples or examples or something like that.

<button id="upload-data" class="btn btn-primary btn-block">Upload New Shapefiles for Regions</button>
</br><br>
<h2>Step 3: Manage Uploaded Polygons</h2>
<select id="manage" class="form-select" aria-label="variable selector" name="manage">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be a table instead of a dropdown menu

@rileyhales rileyhales self-assigned this Mar 16, 2023
@rileyhales
Copy link
Member

Closes #8
Closes #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants