Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.11.0 beta 1 #64

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Release v0.11.0 beta 1 #64

merged 6 commits into from
Nov 2, 2023

Conversation

dr-orlovsky
Copy link
Member

This adds final API-breaking changes from todos for the release:

  • Removes manual strict encoding from InternalPk type (which breaks semantic library id and thus is "breaking")
  • Removes Chain type which is an ambiguous data structure - we added support for Liquid in other LNP/BP libraries, but this library is dedicated to Bitcoin only; thus there are no other chains which can be defined here. Chain was operating as a way to select specific testnet - but this task must be done in the wallet-libraries and not in the consensus library.

@dr-orlovsky dr-orlovsky added *consensus* Issues affecting distributed concensus refactoring Refactoring of the existing code labels Oct 31, 2023
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Oct 31, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Files Coverage Δ
consensus/src/stl.rs 96.8% <ø> (-0.1%) ⬇️
consensus/src/util.rs 0.0% <ø> (-6.1%) ⬇️
dbc/src/tapret/tx.rs 92.3% <100.0%> (+0.5%) ⬆️
dbc/src/tapret/xonlypk.rs 98.1% <100.0%> (-0.2%) ⬇️
seals/src/txout/error.rs 25.0% <ø> (ø)
src/stl.rs 100.0% <ø> (ø)
consensus/src/coding.rs 85.0% <0.0%> (ø)
seals/src/txout/witness.rs 0.0% <0.0%> (ø)
consensus/src/taproot.rs 43.3% <12.5%> (+0.3%) ⬆️
consensus/src/segwit.rs 16.9% <8.3%> (ø)
... and 2 more

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dr-orlovsky dr-orlovsky merged commit aa0e7f7 into master Nov 2, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*consensus* Issues affecting distributed concensus refactoring Refactoring of the existing code
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants