Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements and fixes for consensus types #5 #60

Merged
merged 14 commits into from
Oct 9, 2023
Merged

Conversation

dr-orlovsky
Copy link
Member

@dr-orlovsky dr-orlovsky commented Oct 7, 2023

This is the final large PR completing BP consensus implementation - most of it are the data types moved from BP std crate.

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Attention: 300 lines in your changes are missing coverage. Please review.

Files Coverage Δ
consensus/src/block.rs 33.3% <ø> (+13.3%) ⬆️
consensus/src/coding.rs 83.9% <100.0%> (+1.7%) ⬆️
consensus/src/stl.rs 96.8% <100.0%> (+0.6%) ⬆️
consensus/src/tx.rs 57.0% <100.0%> (+2.1%) ⬆️
consensus/src/script.rs 43.0% <82.8%> (+25.1%) ⬆️
consensus/src/segwit.rs 12.0% <12.5%> (+0.9%) ⬆️
consensus/src/taproot.rs 39.4% <30.0%> (+5.2%) ⬆️
consensus/src/hashtypes.rs 6.9% <6.9%> (ø)
consensus/src/pubkeys.rs 24.8% <24.8%> (ø)
consensus/src/timelocks.rs 9.7% <9.7%> (ø)

📢 Thoughts on this report? Let us know!.

@dr-orlovsky dr-orlovsky marked this pull request as ready for review October 9, 2023 15:43
@dr-orlovsky dr-orlovsky merged commit ed640a8 into master Oct 9, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant