Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename primitives to consensus #57

Merged
merged 4 commits into from
Oct 7, 2023
Merged

Rename primitives to consensus #57

merged 4 commits into from
Oct 7, 2023

Conversation

dr-orlovsky
Copy link
Member

@dr-orlovsky dr-orlovsky commented Oct 7, 2023

Primitives library was originally created to present only those Bitcoin consensus-level data structures which were used in RGB Core.

However, work on wallet-level libraries had required implementing all other data types which may be found in blocks (i.e. part of the consensus layer) - as well as doing encoding for such structures (without it it won't be possible to prepare and publish a new transaction). This library was a natural place for putting this stuff - since once implemented it must never change unless bitcoin consensus rules change with a new soft fork - or a bug is discovered. These are the exact same conditions under which BP Core operates and ossifies, thus, now we have bp-primitives working with all bitcoin consensus-level tasks (aside from validation), and it was quite natural to rename the library.

Now, this bp-consensus crate is an alternative to rust-bitcoin consensus module - but unlike rust-bitcoin these part will maintain immutable and ossified API and are clearly separated from wallet parts (PSBTs, BIP32, addresses etc) which change and evolve all the time.

CC @zoedberg @crisdut @cryptoquick

@dr-orlovsky dr-orlovsky marked this pull request as ready for review October 7, 2023 07:49
@dr-orlovsky dr-orlovsky modified the milestones: v0.11.0, v0.10.x Oct 7, 2023
@dr-orlovsky dr-orlovsky force-pushed the master branch 2 times, most recently from 31b057c to d7fe526 Compare October 7, 2023 09:04
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
consensus/src/block.rs 20.0% <ø> (ø)
consensus/src/coding.rs 82.1% <ø> (ø)
consensus/src/script.rs 17.8% <ø> (ø)
consensus/src/segwit.rs 11.2% <ø> (ø)
consensus/src/sigtypes.rs 27.5% <ø> (ø)
consensus/src/stl.rs 96.2% <ø> (ø)
consensus/src/taproot.rs 34.2% <ø> (ø)
consensus/src/tx.rs 54.8% <ø> (ø)
consensus/src/util.rs 6.1% <ø> (ø)
consensus/src/weights.rs 3.2% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@dr-orlovsky dr-orlovsky merged commit 74b676d into master Oct 7, 2023
@dr-orlovsky dr-orlovsky deleted the primitives branch October 7, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant