Skip to content

Commit

Permalink
Bump CI to GHC 9.10.0 and latest minor versions
Browse files Browse the repository at this point in the history
Bump HTF to a version without custom setup to work around
haskell/cabal#9917
  • Loading branch information
andreasabel committed Apr 23, 2024
1 parent 28a41fc commit 1c7e83c
Show file tree
Hide file tree
Showing 12 changed files with 89 additions and 75 deletions.
93 changes: 42 additions & 51 deletions .github/workflows/haskell-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,45 +8,48 @@
#
# For more information, see https://github.com/andreasabel/haskell-ci
#
# version: 0.17.20231012
# version: 0.19.20240422
#
# REGENDATA ("0.17.20231012",["github","cabal.project"])
# REGENDATA ("0.19.20240422",["github","cabal.project"])
#
name: Haskell-CI
on:
push:
branches:
- master
- ci*
pull_request:
branches:
- master
- ci*
jobs:
linux:
name: Haskell-CI - Linux - ${{ matrix.compiler }}
runs-on: ubuntu-20.04
timeout-minutes:
60
container:
image: buildpack-deps:focal
image: buildpack-deps:jammy
continue-on-error: ${{ matrix.allow-failure }}
strategy:
matrix:
include:
- compiler: ghc-9.8.1
- compiler: ghc-9.10.0.20240413
compilerKind: ghc
compilerVersion: 9.8.1
compilerVersion: 9.10.0.20240413
setup-method: ghcup
allow-failure: false
- compiler: ghc-9.6.3
- compiler: ghc-9.8.2
compilerKind: ghc
compilerVersion: 9.6.3
compilerVersion: 9.8.2
setup-method: ghcup
allow-failure: false
- compiler: ghc-9.4.7
- compiler: ghc-9.6.5
compilerKind: ghc
compilerVersion: 9.4.7
compilerVersion: 9.6.5
setup-method: ghcup
allow-failure: false
- compiler: ghc-9.4.8
compilerKind: ghc
compilerVersion: 9.4.8
setup-method: ghcup
allow-failure: false
- compiler: ghc-9.2.8
Expand Down Expand Up @@ -89,34 +92,18 @@ jobs:
compilerVersion: 8.0.2
setup-method: ghcup
allow-failure: false
- compiler: ghc-7.10.3
compilerKind: ghc
compilerVersion: 7.10.3
setup-method: hvr-ppa
allow-failure: false
fail-fast: false
steps:
- name: apt
run: |
apt-get update
apt-get install -y --no-install-recommends gnupg ca-certificates dirmngr curl git software-properties-common libtinfo5 libnuma-dev
if [ "${{ matrix.setup-method }}" = ghcup ]; then
mkdir -p "$HOME/.ghcup/bin"
curl -sL https://downloads.haskell.org/ghcup/0.1.19.5/x86_64-linux-ghcup-0.1.19.5 > "$HOME/.ghcup/bin/ghcup"
chmod a+x "$HOME/.ghcup/bin/ghcup"
"$HOME/.ghcup/bin/ghcup" config add-release-channel https://raw.githubusercontent.com/haskell/ghcup-metadata/master/ghcup-prereleases-0.0.7.yaml;
"$HOME/.ghcup/bin/ghcup" install ghc "$HCVER" || (cat "$HOME"/.ghcup/logs/*.* && false)
"$HOME/.ghcup/bin/ghcup" install cabal 3.10.1.0 || (cat "$HOME"/.ghcup/logs/*.* && false)
else
apt-add-repository -y 'ppa:hvr/ghc'
apt-get update
apt-get install -y "$HCNAME"
mkdir -p "$HOME/.ghcup/bin"
curl -sL https://downloads.haskell.org/ghcup/0.1.19.5/x86_64-linux-ghcup-0.1.19.5 > "$HOME/.ghcup/bin/ghcup"
chmod a+x "$HOME/.ghcup/bin/ghcup"
"$HOME/.ghcup/bin/ghcup" config add-release-channel https://raw.githubusercontent.com/haskell/ghcup-metadata/master/ghcup-prereleases-0.0.7.yaml;
"$HOME/.ghcup/bin/ghcup" install cabal 3.10.1.0 || (cat "$HOME"/.ghcup/logs/*.* && false)
fi
mkdir -p "$HOME/.ghcup/bin"
curl -sL https://downloads.haskell.org/ghcup/0.1.20.0/x86_64-linux-ghcup-0.1.20.0 > "$HOME/.ghcup/bin/ghcup"
chmod a+x "$HOME/.ghcup/bin/ghcup"
"$HOME/.ghcup/bin/ghcup" config add-release-channel https://raw.githubusercontent.com/haskell/ghcup-metadata/master/ghcup-prereleases-0.0.8.yaml;
"$HOME/.ghcup/bin/ghcup" install ghc "$HCVER" || (cat "$HOME"/.ghcup/logs/*.* && false)
"$HOME/.ghcup/bin/ghcup" install cabal 3.10.3.0 || (cat "$HOME"/.ghcup/logs/*.* && false)
env:
HCKIND: ${{ matrix.compilerKind }}
HCNAME: ${{ matrix.compiler }}
Expand All @@ -128,27 +115,18 @@ jobs:
echo "CABAL_DIR=$HOME/.cabal" >> "$GITHUB_ENV"
echo "CABAL_CONFIG=$HOME/.cabal/config" >> "$GITHUB_ENV"
HCDIR=/opt/$HCKIND/$HCVER
if [ "${{ matrix.setup-method }}" = ghcup ]; then
HC=$("$HOME/.ghcup/bin/ghcup" whereis ghc "$HCVER")
HCPKG=$(echo "$HC" | sed 's#ghc$#ghc-pkg#')
HADDOCK=$(echo "$HC" | sed 's#ghc$#haddock#')
echo "HC=$HC" >> "$GITHUB_ENV"
echo "HCPKG=$HCPKG" >> "$GITHUB_ENV"
echo "HADDOCK=$HADDOCK" >> "$GITHUB_ENV"
echo "CABAL=$HOME/.ghcup/bin/cabal-3.10.1.0 -vnormal+nowrap" >> "$GITHUB_ENV"
else
HC=$HCDIR/bin/$HCKIND
echo "HC=$HC" >> "$GITHUB_ENV"
echo "HCPKG=$HCDIR/bin/$HCKIND-pkg" >> "$GITHUB_ENV"
echo "HADDOCK=$HCDIR/bin/haddock" >> "$GITHUB_ENV"
echo "CABAL=$HOME/.ghcup/bin/cabal-3.10.1.0 -vnormal+nowrap" >> "$GITHUB_ENV"
fi
HC=$("$HOME/.ghcup/bin/ghcup" whereis ghc "$HCVER")
HCPKG=$(echo "$HC" | sed 's#ghc$#ghc-pkg#')
HADDOCK=$(echo "$HC" | sed 's#ghc$#haddock#')
echo "HC=$HC" >> "$GITHUB_ENV"
echo "HCPKG=$HCPKG" >> "$GITHUB_ENV"
echo "HADDOCK=$HADDOCK" >> "$GITHUB_ENV"
echo "CABAL=$HOME/.ghcup/bin/cabal-3.10.3.0 -vnormal+nowrap" >> "$GITHUB_ENV"
HCNUMVER=$(${HC} --numeric-version|perl -ne '/^(\d+)\.(\d+)\.(\d+)(\.(\d+))?$/; print(10000 * $1 + 100 * $2 + ($3 == 0 ? $5 != 1 : $3))')
echo "HCNUMVER=$HCNUMVER" >> "$GITHUB_ENV"
echo "ARG_TESTS=--enable-tests" >> "$GITHUB_ENV"
echo "ARG_BENCH=--enable-benchmarks" >> "$GITHUB_ENV"
echo "HEADHACKAGE=false" >> "$GITHUB_ENV"
if [ $((HCNUMVER >= 91000)) -ne 0 ] ; then echo "HEADHACKAGE=true" >> "$GITHUB_ENV" ; else echo "HEADHACKAGE=false" >> "$GITHUB_ENV" ; fi
echo "ARG_COMPILER=--$HCKIND --with-compiler=$HC" >> "$GITHUB_ENV"
echo "GHCJSARITH=0" >> "$GITHUB_ENV"
env:
Expand Down Expand Up @@ -177,8 +155,18 @@ jobs:
repository hackage.haskell.org
url: http://hackage.haskell.org/
EOF
if $HEADHACKAGE; then
cat >> $CABAL_CONFIG <<EOF
repository head.hackage.ghc.haskell.org
url: https://ghc.gitlab.haskell.org/head.hackage/
secure: True
root-keys: 7541f32a4ccca4f97aea3b22f5e593ba2c0267546016b992dfadcd2fe944e55d
26021a13b401500c8eb2761ca95c61f2d625bfef951b939a8124ed12ecf07329
f76d08be13e9a61a377a85e2fb63f4c5435d40f8feb3e12eb05905edb8cdea89
key-threshold: 3
active-repositories: hackage.haskell.org, head.hackage.ghc.haskell.org:override
EOF
fi
cat $CABAL_CONFIG
- name: versions
run: |
Expand Down Expand Up @@ -232,7 +220,10 @@ jobs:
if [ $((HCNUMVER >= 80200)) -ne 0 ] ; then echo " ghc-options: -Werror=missing-methods" >> cabal.project ; fi
cat >> cabal.project <<EOF
EOF
$HCPKG list --simple-output --names-only | perl -ne 'for (split /\s+/) { print "constraints: $_ installed\n" unless /^(BNFC|bnfc-system-tests)$/; }' >> cabal.project.local
if $HEADHACKAGE; then
echo "allow-newer: $($HCPKG list --simple-output | sed -E 's/([a-zA-Z-]+)-[0-9.]+/*:\1,/g')" >> cabal.project
fi
$HCPKG list --simple-output --names-only | perl -ne 'for (split /\s+/) { print "constraints: $_ installed\n" unless /^(BNFC|Cabal|bnfc-system-tests)$/; }' >> cabal.project.local
cat cabal.project
cat cabal.project.local
- name: dump install plan
Expand Down
5 changes: 3 additions & 2 deletions cabal.haskell-ci
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
-- -- The name of GitHub Action
-- github-action-name:

branches: master ci*
branches: master

-- 2021-01-22 if cabal-version is greater than shipped Cabal, allow newer Cabal version
-- https://github.com/haskell-CI/haskell-ci/issues/468#issuecomment-761865807
-- https://github.com/haskell-CI/haskell-ci/blob/c4f692a254727a11004da819d3bd53a1b5f514ec/cabal.haskell-ci#L43-L45
--
-- By default `installed` constraints are used for packages
-- in global db. We can modify which constraints are used.
installed: +all
installed: +all -Cabal
-- Allow older Cabal to work around https://github.com/haskell/cabal/issues/9917

-- Configure haskell-ci's behavior when presented multiple packages (e.g., a
-- cabal.project file that specifies multiple .cabal files), each of which
Expand Down
7 changes: 4 additions & 3 deletions source/BNFC.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,9 @@ Description:

-- Support range when build with cabal
tested-with:
GHC == 9.8.1
GHC == 9.6.3
GHC == 9.10.0
GHC == 9.8.2
GHC == 9.6.5
GHC == 9.4.8
GHC == 9.2.8
GHC == 9.0.2
Expand All @@ -43,7 +44,7 @@ tested-with:
GHC == 8.4.4
GHC == 8.2.2
GHC == 8.0.2
GHC == 7.10.3
-- GHC == 7.10.3

extra-doc-files:
README.md
Expand Down
4 changes: 2 additions & 2 deletions source/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ CABAL_BUILDDIR_SUFFIX=
CABAL_BUILD_OPTS = --enable-tests
# --builddir=dist-ghc-$(GHC_VERSION)$(CABAL_BUILDDIR_SUFFIX)
CABAL_CONFIGURE_OPTS = --enable-tests
CABAL_INSTALL_OPTS = $(CABAL_CONFIGURE_OPTS) $(CABAL_BUILD_OPTS) --overwrite-policy=always
CABAL_INSTALL_OPTS = --overwrite-policy=always
CABAL_TEST_OPTS = $(CABAL_BUILD_OPTS)

CABAL = cabal $(CABAL_OPTS)
Expand Down Expand Up @@ -38,7 +38,7 @@ cabal-test:
doctest: build doctest-install doctest-quick

doctest-install:
cabal install doctest --program-suffix=-${GHC_VERSION}
cabal install doctest --ignore-project --program-suffix=-${GHC_VERSION}

doctest-quick:
cabal repl -w doctest-${GHC_VERSION} --repl-options=-Wno-type-defaults
Expand Down
4 changes: 2 additions & 2 deletions source/stack-9.6.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
resolver: lts-22.0
compiler: ghc-9.6.3
resolver: lts-22.18
compiler: ghc-9.6.4
compiler-check: newer-minor
4 changes: 2 additions & 2 deletions source/stack-9.8.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
resolver: nightly-2023-12-19
compiler: ghc-9.8.1
resolver: nightly-2024-04-22
compiler: ghc-9.8.2
compiler-check: newer-minor

packages:
Expand Down
4 changes: 2 additions & 2 deletions stack-9.6.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
resolver: lts-22.0
compiler: ghc-9.6.3
resolver: lts-22.18
compiler: ghc-9.6.4
compiler-check: newer-minor

packages:
Expand Down
10 changes: 5 additions & 5 deletions stack-9.8.yaml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
resolver: nightly-2023-12-19
compiler: ghc-9.8.1
resolver: nightly-2024-04-22
compiler: ghc-9.8.2
compiler-check: newer-minor

packages:
- source
- testing

extra-deps:
- aeson-2.2.1.0
- th-abstraction-0.6.0.0
# extra-deps:
# - aeson-2.2.1.0
# - th-abstraction-0.6.0.0
12 changes: 6 additions & 6 deletions testing/bnfc-system-tests.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,10 @@ build-type: Simple
cabal-version: >=1.10

tested-with:
GHC == 9.8.1
GHC == 9.6.3
GHC == 9.4.7
GHC == 9.10.0
GHC == 9.8.2
GHC == 9.6.5
GHC == 9.4.8
GHC == 9.2.8
GHC == 9.0.2
GHC == 8.10.7
Expand Down Expand Up @@ -88,10 +89,9 @@ executable bnfc-system-tests
, HUnit >= 1.2
, shelly >= 1.9
, filepath
-- filepath >= 1.4.2.1
, text
, HTF >= 0.14.0.5
-- API change in HTF-0.15.0.0 (issue #416)
, HTF >= 0.15.0.0
-- API change in HTF-0.15 (issue #416)
, random
, string-qq

Expand Down
1 change: 1 addition & 0 deletions testing/regression-tests/479_LabelsCaseSensitive/good01.in
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2 ^ (2 ** 2)
10 changes: 10 additions & 0 deletions testing/regression-tests/479_LabelsCaseSensitive/good01.out
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@

Parse Successful!

[Abstract Syntax]

Eexp (EInt 2) (EExp (EInt 2) (EInt 2))

[Linearized tree]

2 ^ (2 ** 2)
10 changes: 10 additions & 0 deletions testing/regression-tests/479_LabelsCaseSensitive/test.cf
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
-- Andreas, 2024-04-23, issue #479:
-- Support case-variants in labels also in the C backend.

Eexp. Exp ::= Exp "^" Exp1 ;
EExp. Exp ::= Exp "**" Exp1 ;
EInt. Exp1 ::= Integer ;

coercions Exp 1 ;

comment "--" ;

0 comments on commit 1c7e83c

Please sign in to comment.