Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethiopian calendar support: use period picker instead of date picker #206

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mestachs
Copy link
Contributor

@mestachs mestachs commented Nov 13, 2023

To avoid a lot of hassle, moving to a datepicker that already support different calendars help a lot.

I've modified the existing period picker (used in the contract modules for start and end period) to accept a new mode "active"
It will display the 2 years first, end users can still type (ex 201601 and will get Meskerem 2016 or January 2016)

image

Sample screenshot on gregorian calendar (before and after)

image

note

  • that it fixes a weird issue where if you put 01/01/2023 you didn't get all the contracts...
  • I've tried to support to parse the date format in the url so the page doesn't crash and still filter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant