-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ifc_import.rb #61
base: main
Are you sure you want to change the base?
Conversation
ifc_import is broken on SketchUp Versions greater then 17. The result with this commit is it fails silently.
Thanks, good spot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change request, otherwise a good bugfix!
@@ -142,7 +142,7 @@ def improve_definition_names(model) | |||
def ifc_cleanup(model, import_path) | |||
puts 'Start IFC cleanup' | |||
model.start_operation('IFC Cleanup', true) | |||
merge_faces(model.entities) | |||
merge_faces(model.active_entities) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should remain unchanged, the import is always in model.entities, not in the users active entities.
Friend, I would like to include a folder with personalized sketchup classification, is it possible? |
Yes, as long as it matches the structure from the other SKC's. The IFC
mapping had to know which parameter to put where in the
IfcClassification(Reference).
You need to add the SKC to the SketchUp classifications folder or in the
classifications folder of IFC manager, then add the name of the file in the
settings.yml file in the IFC manager plugin folder.
Please let me know if you run into problems
Op vr 30 aug 2024 15:17 schreef Marcelo Carvalho ***@***.***>:
… Friend, I would like to include a folder with personalized sketchup
classification, is it possible?
—
Reply to this email directly, view it on GitHub
<#61 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCZVLGPYUNEVXREZTW72QLZUBWGZAVCNFSM6AAAAABKKQYQZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRRGIZDQMZWGE>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
I also can't export with the class manager, I used the DIN 276-1 folder, just with the default sketchup classification, could you tell me where the IFC manager plug-in folder is on the computer. |
ifc_import is broken on SketchUp Versions greater then 17. The result without this commit is it fails silently.
See https://ruby.sketchup.com/Sketchup/Model.html#import-instance_method