Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Develop #1

wants to merge 2 commits into from

Conversation

ajwood
Copy link

@ajwood ajwood commented Feb 25, 2014

  • Optimized matrix trace computation (was too memory-hungry for large matrices)
  • Removed positive bias in amoeba optimization

@gdevenyi
Copy link

@vfonov thoughts on this?

@vfonov
Copy link
Member

vfonov commented May 22, 2020

it's the same change as BIC-MNI/mni_autoreg@2166db5
it's another copy of amoeba optimization code, I don't know which tool actually uses this one

@vfonov
Copy link
Member

vfonov commented May 22, 2020

I had to make configuration parameter to make sure we can reproduce old results: BIC-MNI/mni_autoreg@b2440b2

@gdevenyi
Copy link

Okay, so we can break out 57386e3 to merge seperately?

@vfonov
Copy link
Member

vfonov commented May 23, 2020

would be good to find out if this algorithm actually is used in something important.

@gdevenyi
Copy link

Good question. Clearly the original author came across it for some application.

@vfonov
Copy link
Member

vfonov commented May 23, 2020

then we might have to make another compilation switch to reproduce the old behaviour if needed.

@gdevenyi
Copy link

I see your examples you linked. I'll try and mirror a port of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants