Structure_Engine: flipping of bars fixed to take release into account

[pawelbaran]

Issues addressed by this PR

Closes #3446

Test files

On SharePoint

Changelog

• Updated Bar.Flip() to include updates to the SectionProperty, ShapeProfile, Releases and OrientationAngle.

Additional comments

The KiteProfile is the only one I cannot get to work - we may need to add a MirrorAboutY property to it.

[pawelbaran]

@peterjamesnugent @IsakNaslundBh when working on this one, I started thinking whether the orientation angle should not be negated too? Not entirely sure about it, but a part of me argued for that - happy for you to take over this and make an informed decision 👍

[pawelbaran]

@BHoMBot check required

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[pawelbaran]

@BHoMBot check unit-tests
@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check unit-tests
• check dataset-compliance
• check copyright-compliance

[peterjamesnugent]

Happy that the script works as intended, minor change for the code if you think it's worth changing.

I have added a check for a horizontal bar, happy this works for the BarRelease.

As discussed offline, the orientational angle should update too, this needs to be set dependent on whether Bar is vertical if not:

• If Bar is vertical, newOrientationAngle = -orientationalAngle + pi()
• If Bar is not vertical ,newOrientationAngle = -orientationAngle

I have added a bit in the script to show this.

[IsakNaslundBh]

There is a method here: https://github.com/BHoM/ETABS_Toolkit/blob/develop/Etabs_Adapter/CRUD/Create/Bar.cs that potentially could be migrated over. Covers most things I think, but still to be double checked that all things are covered. Mirroring of sections is one thing that might need a bit of attention I think, which is not handled in that method.

[pawelbaran]

I feel like I am least informed of us three @IsakNaslundBh @peterjamesnugent - is there a chance you could agree between your duo on how to finalise this PR? To me anything would work 😉

[bhombot-ci]

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on ETABS_Toolkit

[bhombot-ci]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

[IsakNaslundBh]

See some comments below. Think general work on sections make sense.

One alternative approach to the general filtering for if a profile should be flipped or not, that would be broadening the scope of this though, is to add a new Quary method in spatial engine for IProfile, returning the level of symmetry for the profile. Would then also need to add an enum that is specifying this level of symmetry though, but then you ifstatement could be changed to something like if(profile.ISymmetry() = Symmetry.DoubleSymetric) => return oldprofile.

Not sure if that is widening the scope to much for this though, but just a thought, as I think that potentially could be useful elsewhere as well.

[IsakNaslundBh]

Would change this to a warning and return the old profile.

[IsakNaslundBh]

If this is problematic, might be good to add a warning about it, or let it fallback to the other method

[IsakNaslundBh]

Need method separator lines between all methods /***************************************************/

[IsakNaslundBh]

Think the offset also need to be handled here.