Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[비즈니스] 비밀번호 찾기 인증번호 확인 버튼 추가 #372

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

chaeseungyun
Copy link
Contributor

  • Close #ISSUE_NUMBER

What is this PR? 🔍

  • 기능 :
  • issue : #

Changes 📝

QA때 인증번호 확인 과정 경험이 어색하다는 의견이 많아서 인증번호 확인 버튼을 추가했습니다
그리고 사용자는 인증 확인 후에도 인증번호 및 휴대폰 번호를 조작할 수 있도록 변경된 상태입니다
따라서 인증 성공 후에 사용자가 인증번호나 휴대폰 번호를 수정하면 다음 페이지로 넘어갈 수 없도록 수정했습니다(네이버 회원가입 참고)

인증번호 발송되었음을 확인할 수 있도록 toast 메시지를 띄웠습니다!

ScreenShot 📷

image
image
image
image

Test CheckList ✅

  • test 1
  • test 2
  • test 3

Precaution

✔️ Please check if the PR fulfills these requirements

  • It's submitted to the correct branch, not the develop branch unconditionally?
  • If on a hotfix branch, ensure it targets main?
  • There are no warning message when you run yarn lint

@chaeseungyun chaeseungyun self-assigned this Jul 9, 2024
@github-actions github-actions bot requested review from daepan and KimKyungYun July 9, 2024 00:36
Copy link

@KimKyungYun KimKyungYun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

src/page/Auth/FindPassword/Verify/index.tsx Show resolved Hide resolved
Copy link
Contributor

@daepan daepan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

}

.button {
background-color: #eeeeee;
border-radius: 4px;
height: 50px;
width: 40%;
cursor: pointer;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaeseungyun chaeseungyun merged commit 403fd39 into develop Jul 10, 2024
2 checks passed
@github-actions github-actions bot deleted the feat/add_confirm_button branch July 10, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants