Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[공통] 로그인시 이메일 검증 제거 #347

Merged
merged 2 commits into from
Jun 7, 2024
Merged

[공통] 로그인시 이메일 검증 제거 #347

merged 2 commits into from
Jun 7, 2024

Conversation

MinGu-Jeong
Copy link
Contributor

What is this PR? 🔍

Changes 📝

zod의 이메일검증 로직을 제거해서 아이디형식으로도 로그인이 가능하도록 수정했습니다.

ScreenShot 📷

스크린샷 2024-06-07 오후 1 23 22

Test CheckList ✅

Precaution

✔️ Please check if the PR fulfills these requirements

  • It's submitted to the correct branch, not the develop branch unconditionally?
  • If on a hotfix branch, ensure it targets main?
  • There are no warning message when you run yarn lint

@MinGu-Jeong MinGu-Jeong added the ✨ Feature 기능 개발 label Jun 7, 2024
@MinGu-Jeong MinGu-Jeong self-assigned this Jun 7, 2024
@MinGu-Jeong MinGu-Jeong merged commit c86056e into develop Jun 7, 2024
2 checks passed
@MinGu-Jeong MinGu-Jeong deleted the feature/#346/delete-email-validation-logic branch June 7, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeseungyun chaeseungyun chaeseungyun approved these changes

@junghaesung79 junghaesung79 junghaesung79 approved these changes

@KimKyungYun KimKyungYun Awaiting requested review from KimKyungYun

Assignees

@MinGu-Jeong MinGu-Jeong

Labels
✨ Feature 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[공통] 로그인시 이메일 검증 로직 삭제
3 participants
@MinGu-Jeong @junghaesung79 @chaeseungyun