Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[비즈니스] 이벤트, 메뉴 관련 이슈 수정 #332

Merged
merged 6 commits into from
May 10, 2024

Conversation

chaeseungyun
Copy link
Contributor

@chaeseungyun chaeseungyun commented May 10, 2024

What is this PR? 🔍

Changes 📝

ScreenShot 📷

  1. 이벤트 추가, 수정 시 일반 텍스트를 입력하도록 변경했습니다
  2. 메뉴 추가 및 수정 시 이미지가 정상적으로 추가 및 삭제 되도록 변경했습니다.
  3. 메뉴 수정 시 카테고리를 1개 이상 넣어야 하도록 변경했습니다.

Test CheckList ✅

Precaution

✔️ Please check if the PR fulfills these requirements

  • It's submitted to develop branch, not the main branch
  • Did you merge recent develop branch?

@chaeseungyun chaeseungyun self-assigned this May 10, 2024
Comment on lines -27 to +31
imageFile, imgRef, saveImgFile, uploadError,
imageFile, imgRef, saveImgFile, uploadError, setImageFile,
} = useImagesUpload();
const imageObject = {
imageFile, imgRef, saveImgFile, uploadError, setImageFile,
}; // AddMenuImgModal에 넘길 props
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구두) 요렇게하면 새로운 객체를 만드는 게 아닌, 필요한 값을 꺼내쓴 느낌을 줄 수 있을거로 보여용. 타입도 안정적이구요

const imageObject = useImagesUpload();
const { imageFile, ... } = imageObject;

@kimeodml kimeodml merged commit 22a88b9 into develop May 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[비즈니스] QA 이슈
3 participants