Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[코인오너] 메뉴판 수정 #321

Merged
merged 3 commits into from
May 9, 2024
Merged

[코인오너] 메뉴판 수정 #321

merged 3 commits into from
May 9, 2024

Conversation

kimeodml
Copy link
Contributor

@kimeodml kimeodml commented May 8, 2024 •
edited by chaeseungyun
Loading

What is this PR? 🔍

Changes 📝

  • 피그마와 동일하게 메뉴판을 수정하였습니다.
    • 메뉴 카테고리에 따라 활성/비활성 버튼이 존재
    • 스크롤 위치에 따른 버튼 활성화

ScreenShot 📷

Test CheckList ✅

  • 피그마와 동일한 디자인지 확인
  • 버튼을 누르면 해당 카테고리 메뉴로 이동하는지 확인
  • 스크롤 위치에 따라 해당하는 메뉴 버튼이 활성화되는지 확인

Precaution

✔️ Please check if the PR fulfills these requirements

  • It's submitted to develop branch, not the main branch
  • Did you merge recent develop branch?

chaeseungyun
chaeseungyun approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@chaeseungyun chaeseungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코인과 동일한 디자인, 메뉴 카테고리 클릭 시 이동, 스크롤 시 상단바 고정 잘 동작되는거 확인했습니다

@kimeodml kimeodml merged commit 6a4216c into develop May 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeseungyun chaeseungyun chaeseungyun approved these changes

@KimKyungYun KimKyungYun Awaiting requested review from KimKyungYun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[코인오너] 메뉴판 수정
2 participants
@kimeodml @chaeseungyun